Repository navigation
fix: exclude symlinks from project scans - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File symlinks were falling through the directory check and being treated as source files. A link to source outside the workspace would then be read by
buildFullMap, so unrelated files could enter the map and later chat context. Dangling links were also returned by the scan.Only include regular files after handling directories. This skips file and directory symlinks without changing normal extension filtering or ignored directories.
Added a real temporary-filesystem regression covering external file links, internal aliases, dangling links, directory links, nested regular files, and the resulting full map.
Verification:
npm test- 46 passed, 0 failed.node --checkon both changed files andgit diff --checkpass.