Skip to content

fix: exclude symlinks from project scans - #1

Merged
Mrun25 merged 2 commits into
mainfrom
fix/skip-symlink-scans
Oct 9, 2026
Merged

Mrun25 merged 2 commits into
mainfrom
fix/skip-symlink-scans

Conversation

@Mrun25

@Mrun25 Mrun25 commented Oct 9, 2026

Copy link
Copy Markdown
Owner

File symlinks were falling through the directory check and being treated as source files. A link to source outside the workspace would then be read by buildFullMap, so unrelated files could enter the map and later chat context. Dangling links were also returned by the scan.

Only include regular files after handling directories. This skips file and directory symlinks without changing normal extension filtering or ignored directories.

Added a real temporary-filesystem regression covering external file links, internal aliases, dangling links, directory links, nested regular files, and the resulting full map.

Verification:

  • Before the fix: 43 passed, 3 new regression assertions failed.
  • After the fix, on the committed branch: npm test - 46 passed, 0 failed.
  • node --check on both changed files and git diff --check pass.
  • No API calls or paid services used. Tested locally on Linux; Windows symlink permissions were not tested.

Copilot AI balanced review requested due to automatic review settings October 9, 2026 18:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Mrun25
Mrun25 merged commit ada3d52 into main Oct 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants