Skip to content

bug: shared-supervisor-ha helm overlay list looks like an image tag #5448

Closed

Description

@ChristianZaccaria

User Story

I use OpenShell and run the Kubernetes e2e tasks, including mise run e2e:kubernetes:shared-supervisor-ha. I directly encountered the e2e:kubernetes:shared-supervisor-ha run line colon-joining three Helm overlay paths into one string, so that path.yaml:deploy/... reads as a container image reference.

Reference: https://github.com/NVIDIA/OpenShell/blob/main/tasks/test.toml#L321-L322

Problem Statement

The e2e:kubernetes:shared-supervisor-ha task in tasks/test.toml sets OPENSHELL_E2E_KUBE_EXTRA_VALUES to a single colon-delimited list of Helm values files. The middle join produces a substring of the form helm/openshell/ci/values-supervisor-ha.yaml:deploy. That matches container image name:tag syntax even though it is a path list, not an image.

Impact / Why This Matters

Readers and image-reference scanners treat that substring as an unpinned image named helm/openshell/ci/values-supervisor-ha.yaml with tag deploy. That is not a workload image and is not what the task deploys. The current workaround is to rewrite or except the line downstream. That diverges from main and conflicts the next time this task's overlays change. The extra-values contract itself does not need to change.

Acceptance Criteria

  • mise run e2e:kubernetes:shared-supervisor-ha still builds the same OPENSHELL_E2E_KUBE_EXTRA_VALUES list, in the same overlay order, including any caller-appended overlays.
  • The task run script no longer contains a single-token *.yaml:deploy/... substring that matches image name:tag syntax.

Reproduction Steps

  1. Check out OpenShell main.
  2. Open tasks/test.toml and find ["e2e:kubernetes:shared-supervisor-ha"].
  3. Read the run field. The colon-joined overlay list includes .../values-supervisor-ha.yaml:deploy/helm/....
  4. That substring is a Helm values path list, but it matches image name:tag form (.../values-supervisor-ha.yaml:deploy).

Suggested UX (if applicable)

mise run e2e:kubernetes:shared-supervisor-ha keeps the same extra-values contract. OPENSHELL_E2E_KUBE_EXTRA_VALUES remains a colon-separated list of Helm values files at runtime.

Environment

  • OpenShell: main (includes e2e:kubernetes:shared-supervisor-ha)
  • OS: macOS 15 (reproduction is the task definition, not a running cluster)
  • OpenShell deployment mode and runtime: Kubernetes e2e task in tasks/test.toml; no cluster required to observe the string

Logs

OPENSHELL_E2E_KUBE_EXTRA_VALUES="deploy/helm/openshell/ci/values-high-availability.yaml:deploy/helm/openshell/ci/values-supervisor-ha.yaml:deploy/helm/openshell/ci/values-tls-port-forward.yaml..."

The scanner-visible token is helm/openshell/ci/values-supervisor-ha.yaml:deploy.

Activity

  1. added
    state:acceptedA maintainer decided OpenShell should pursue this issue
    and removed
    state:triage-neededOpened without agent diagnostics and needs triage
    on Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    state:acceptedA maintainer decided OpenShell should pursue this issue

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions