Repository navigation
Description
User Story
I use OpenShell and run the Kubernetes e2e tasks, including mise run e2e:kubernetes:shared-supervisor-ha. I directly encountered the e2e:kubernetes:shared-supervisor-ha run line colon-joining three Helm overlay paths into one string, so that path.yaml:deploy/... reads as a container image reference.
Reference: https://github.com/NVIDIA/OpenShell/blob/main/tasks/test.toml#L321-L322
Problem Statement
The e2e:kubernetes:shared-supervisor-ha task in tasks/test.toml sets OPENSHELL_E2E_KUBE_EXTRA_VALUES to a single colon-delimited list of Helm values files. The middle join produces a substring of the form helm/openshell/ci/values-supervisor-ha.yaml:deploy. That matches container image name:tag syntax even though it is a path list, not an image.
Impact / Why This Matters
Readers and image-reference scanners treat that substring as an unpinned image named helm/openshell/ci/values-supervisor-ha.yaml with tag deploy. That is not a workload image and is not what the task deploys. The current workaround is to rewrite or except the line downstream. That diverges from main and conflicts the next time this task's overlays change. The extra-values contract itself does not need to change.
Acceptance Criteria
-
mise run e2e:kubernetes:shared-supervisor-hastill builds the sameOPENSHELL_E2E_KUBE_EXTRA_VALUESlist, in the same overlay order, including any caller-appended overlays. - The task
runscript no longer contains a single-token*.yaml:deploy/...substring that matches imagename:tagsyntax.
Reproduction Steps
- Check out OpenShell
main. - Open
tasks/test.tomland find["e2e:kubernetes:shared-supervisor-ha"]. - Read the
runfield. The colon-joined overlay list includes.../values-supervisor-ha.yaml:deploy/helm/.... - That substring is a Helm values path list, but it matches image
name:tagform (.../values-supervisor-ha.yaml:deploy).
Suggested UX (if applicable)
mise run e2e:kubernetes:shared-supervisor-ha keeps the same extra-values contract. OPENSHELL_E2E_KUBE_EXTRA_VALUES remains a colon-separated list of Helm values files at runtime.
Environment
- OpenShell:
main(includese2e:kubernetes:shared-supervisor-ha) - OS: macOS 15 (reproduction is the task definition, not a running cluster)
- OpenShell deployment mode and runtime: Kubernetes e2e task in
tasks/test.toml; no cluster required to observe the string
Logs
OPENSHELL_E2E_KUBE_EXTRA_VALUES="deploy/helm/openshell/ci/values-high-availability.yaml:deploy/helm/openshell/ci/values-supervisor-ha.yaml:deploy/helm/openshell/ci/values-tls-port-forward.yaml..."
The scanner-visible token is helm/openshell/ci/values-supervisor-ha.yaml:deploy.
Activity