Repository navigation
fix(docker): warn on unsupported Docker Engine versions - #5369
Merged
TaylorMutch merged 1 commit intoNov 10, 2026
Merged
Conversation
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
Contributor
Author
|
@elezar @TaylorMutch PTAL when you get a chance, and could one of you accept #5314 (and add an |
github-actions
Bot
requested review from
FrostGod,
drew,
elezar,
mrunalp and
russellb
November 10, 2026 07:25
TaylorMutch
approved these changes
Nov 10, 2026
TaylorMutch
left a comment
Collaborator
There was a problem hiding this comment.
Approved for the warning-only startup check proposed in the triage discussion on #5314. The change reports the detected Docker Engine version and the documented 28.0 minimum while preserving startup behavior. The linked issue should reflect this warning-only outcome: this change does not make Docker 26.1.5 work or reject it up front.
Collaborator
|
/ok to test 1d646bc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Docker driver now warns at startup when the Docker Engine is older than the documented 28.0 minimum.
Related Issue
Closes #5314
Changes
Testing
cargo fmt,cargo clippy -p openshell-driver-docker --lib --tests -- -D warningsand the new unit tests pass.Checklist