Skip to content

fix(docker): warn on unsupported Docker Engine versions - #5369

Merged
TaylorMutch merged 1 commit into
NVIDIA:mainfrom
ericcurtin:fix/5314-docker-version-warn/ericcurtin
Nov 10, 2026
Merged

TaylorMutch merged 1 commit into
NVIDIA:mainfrom
ericcurtin:fix/5314-docker-version-warn/ericcurtin

Conversation

@ericcurtin

Copy link
Copy Markdown
Contributor

Summary

The Docker driver now warns at startup when the Docker Engine is older than the documented 28.0 minimum.

Related Issue

Closes #5314

Changes

  • Warn with the detected and minimum versions.

Testing

  • Checks appropriate to the affected code and behavior pass
  • Unit tests added/updated (if applicable)
  • E2E tests added/updated (if applicable)

cargo fmt, cargo clippy -p openshell-driver-docker --lib --tests -- -D warnings and the new unit tests pass.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Signed-off-by: Eric Curtin <eric.curtin@docker.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 7, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ericcurtin

Copy link
Copy Markdown
Contributor Author

@elezar @TaylorMutch PTAL when you get a chance, and could one of you accept #5314 (and add an area: label) so the issue and review readiness checks can pass? /ok to test 1d646bc3c93c96aa7a87561885f3f3a9999576d8 if it looks good. Thank you!

@TaylorMutch TaylorMutch added the area:drivers Compute and secret drivers, host OS/architecture support, backend isolation, and lifecycle. label Nov 10, 2026

@TaylorMutch TaylorMutch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for the warning-only startup check proposed in the triage discussion on #5314. The change reports the detected Docker Engine version and the documented 28.0 minimum while preserving startup behavior. The linked issue should reflect this warning-only outcome: this change does not make Docker 26.1.5 work or reject it up front.

@TaylorMutch

Copy link
Copy Markdown
Collaborator

/ok to test 1d646bc

@TaylorMutch
TaylorMutch added this pull request to the merge queue Nov 10, 2026
Merged via the queue into NVIDIA:main with commit 4453e51 Nov 10, 2026
89 of 91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:drivers Compute and secret drivers, host OS/architecture support, backend isolation, and lifecycle.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docker driver: no sandbox can start on Debian 13 with Debian's docker.io (26.1.5): "getent unable to find entry "1000:1000""

2 participants