Repository navigation
[ENHANCEMENT]: Provide helper function cuco::experimental::make_static_set et al #370
Description
Is your feature request related to a problem? Please describe.
I would like a function called make_static_set that will create a static set that will infer the template arguments from the function call.
Describe the solution you'd like
Instead of:
auto set = cuco::experimental::static_set<MyKeyType, MyExtent, MyThreadScope, MyKeyEqual>(capacity, cuco::empty_key(-1), MyKeyEqual(123));I could write:
auto set = cuco::experimental::make_static_set(capacity, cuco::empty_key(-1), MyKeyEqual(123));Notice how it's much smaller and I'm not repeating myself. Notice the addition of the work "make". This is consistent with the stdlib's usage of the word make in, for example, std::make_tuple
Describe alternatives you've considered
I can do without but its wordy. Doing this doesn't add much work for cuco. Cuco can modify some of its tests to use this form of the instantiation so that it is tested well in CI.
Additional context
Inference only works on functions, not classes: https://stackoverflow.com/questions/797594/when-a-compiler-can-infer-a-template-parameter
Here's how make_tuple works: https://en.cppreference.com/w/cpp/utility/tuple/make_tuple
Activity
[-][ENHANCEMENT]: Helper functions for making a static_set et al[/-][+][ENHANCEMENT]: Provide helper function cuco::experimental::make_static_set et al[/+]jrhemstad commentedon Sep 21, 2023
This is no longer true as of C++17 with "Class Template Argument Deduction" (CTAD). CTAD has all but made
make_*functions obsolete.sleeepyjack commentedon Sep 21, 2023
Yes, the error you are seeing is due to us struggling with getting CTAD right 🙃
I wonder if this is something we can fix with a deduction guide?
PointKernel commentedon Sep 21, 2023
There are a few things in my mind to improve the situation. Wait for my PR(s)
esoha-nvidia commentedon Sep 21, 2023
I can test it very easily if you need. Let me know.
PointKernel commentedon Sep 22, 2023
https://godbolt.org/z/4Y4WYfxcK
@esoha-nvidia actually, your example would deduce just fine even with the current implementation. Any other examples you would like to make them work?
PointKernel commentedon Oct 2, 2023
Updates: now with #346 being merged. Plain integers can be deduced as well.
https://godbolt.org/z/Wsbr17fh5