Repository navigation
Minor improvements for arrow_filter_policy - #654
Merged
PointKernel merged 5 commits intoDec 10, 2024
Merged
PointKernel merged 5 commits into
PointKernel merged 5 commits into
Conversation
mhaseeb123
marked this pull request as ready for review
December 10, 2024 21:26
PointKernel
reviewed
Dec 10, 2024
Co-authored-by: Yunsong Wang <yunsongw@nvidia.com>
Merged
3 tasks done
Member
|
/ok to test |
PointKernel
added
type: improvement
mhaseeb123
commented
Dec 10, 2024
Member
|
/ok to test |
PointKernel
approved these changes
Dec 10, 2024
PointKernel
left a comment
PointKernel
left a comment
Member
There was a problem hiding this comment.
Thanks for the quick fix @mhaseeb123
mhaseeb123
deleted the
fea/minor-improvements-for-arrow-filter-policy
branch
December 10, 2024 23:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR make the hasher to
arrow_filter_policya template type for users to simply pass the hasher without specifying theKeytype twice. See this comment for discussion: #653 (comment). Also update member typesargument_typeandhash_result_typeto directly useKeyandstd::uint64_tfor this policy.