Repository navigation
docs: add custom argument example - #470
Open
efegokdemir wants to merge 5 commits into
Open
efegokdemir wants to merge 5 commits into
efegokdemir wants to merge 5 commits into
Conversation
Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>
Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>
Collaborator
|
I think a big drawback of current approach for handling custom arguments is lack of their discoverability via CLI. Implementing that is outside of this PR's scope though. |
Signed-off-by: Efe Gökdemir <gokdemirefe1903@gmail.com>
Signed-off-by: Efe Gökdemir <gokdemirefe1903@gmail.com>
Collaborator
|
/ok to test 46d8baa |
Signed-off-by: Efe Gökdemir <gokdemirefe1903@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #87 by adding a focused example for applications that need to consume their own command-line arguments before NVBench parses the remaining options.
Changes
custom_args.cuexample usingNVBENCH_MAIN_CUSTOM_ARGS_HANDLER.--iterationsoption before handing arguments to NVBench.Testing
git diff --check origin/main...HEAD— passed.clang-format --dry-run --Werror examples/custom_args.cu— passed.nvccis not installed in this environment.cmakeis not installed in this environment.Notes
The example uses the existing customization hook and keeps the benchmark CPU-only so the argument-handling pattern is easy to run and inspect without requiring a GPU at runtime. AI assistance was used during implementation; the final diff and validation were reviewed manually.