Skip to content

refactor: prepare service consumers for owned service handles - #2002

Open
Javagedes wants to merge 1 commit into
OpenDevicePartnership:mainfrom
Javagedes:personal/joeyvagedes/service-arc-prep
Open

Javagedes wants to merge 1 commit into
OpenDevicePartnership:mainfrom
Javagedes:personal/joeyvagedes/service-arc-prep

Conversation

@Javagedes

Copy link
Copy Markdown
Contributor

Description

Stop depending on &'static service references where a Service handle can be stored instead:

  • MP: store the arch timer as Service.
  • controller_driver: store Service in Inner.
  • SMBIOS: register the owned service instead of leaking it.
  • patina_test: pass Service instead of a leaked &'static Recorder.
  • Benches and TPL guard: avoid copying service handles.

No public API changes.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

CI and boot with Q35 / SBSA

Integration Instructions

N/A

Stop depending on &'static service references where a Service handle can
be stored instead:

- MP: store the arch timer as Service<dyn ArchTimerFunctionality>.
- controller_driver: store Service<dyn ProtocolServices> in Inner.
- SMBIOS: register the owned service instead of leaking it.
- patina_test: pass Service<Recorder> instead of a leaked &'static Recorder.
- Benches and TPL guard: avoid copying service handles.

No public API changes.
@patina-automation

patina-automation Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

✅ QEMU Validation Passed

All QEMU validation jobs completed successfully.

Note: Q35 is only built on Windows hosts (QEMU boot is disabled due to a QEMU vfat issue).

Workflow run: https://github.com/OpenDevicePartnership/patina/actions/runs/44365309945

Boot Time to EFI Shell

Platform Elapsed
ArmVirt (Linux Host) 17.8s
Q35 (Linux Host) 55.9s

Dependencies

Repository Ref
patina eb2a79a
patina-dxe-core-qemu 422e50e
patina-fw-patcher 820b0ae
patina-qemu firmware v4.1.5
patina-qemu build script 5945583

Binary Size Report

Platform Commit Δ Debug Δ Release Δ Debug
(LZMA)
Δ Release
(LZMA)
Q35 (x86_64) Base:65c2a2d
PR:eb2a79a
 
1.19 MB
1.19 MB
Δ +1.50 KB
951.00 KB
953.50 KB
Δ +2.50 KB
460.46 KB
461.55 KB
Δ +1.10 KB
375.15 KB
375.94 KB
Δ +814.00 B
ArmVirt (aarch64) Base:65c2a2d
PR:eb2a79a
 
1.08 MB
1.08 MB
Δ +1.00 KB
870.00 KB
871.50 KB
Δ +1.50 KB
375.02 KB
375.25 KB
Δ +244.00 B
307.11 KB
307.36 KB
Δ +252.00 B

Compressed sizes use LZMA-alone format at preset 6 (xz --format=lzma -6).

Shared QEMU integration: 422e50e.

This comment was automatically generated by the Patina QEMU PR Validation Post workflow.

@github-actions github-actions Bot added the impact:non-functional Does not have a functional impact label Nov 18, 2026
@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
patina_dxe_core/src/cpu/mp_services.rs 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact:non-functional Does not have a functional impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants