Repository navigation
Documentation updates - #37
Merged
Merged
Conversation
Potherca
reviewed
Aug 16, 2017
| "dealerdirect/phpcodesniffer-composer-installer": "*", | ||
| "wimg/php-compatibility": "*", | ||
| "wp-coding-standards/wpcs": "*", | ||
| "object-calisthenics/phpcs-calisthenics-rules": "*" |
Member
There was a problem hiding this comment.
I would suggest placing the requirements in alphabetical order, specifically because "config": {"sort-packages": true} is becoming more and more popular
Contributor
Author
There was a problem hiding this comment.
Sorted. I have left out the configuration, since that is not in scope of the example ;)
Potherca
approved these changes
Aug 16, 2017
Potherca
left a comment
Potherca
left a comment
Member
There was a problem hiding this comment.
One minor suggestion for improvement. Other than that looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Updated some aspects of the documentation.
Related Issues