Repository navigation
RIGHT: return all of the text when num_chars exceeds its length - #5044
Merged
Merged
Conversation
RIGHT("abc",5) returned "bc" because the start offset went negative and
mb_substr then counted it from the end of the string. Excel returns the
whole text when num_chars is greater than its length, so clamp the offset
at 0.
Collaborator
|
Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
Why is this change needed?
RIGHTdrops characters from the start of the result whennum_charsis bigger than the text:The start offset
mb_strlen($value) - $charsgoes negative, andmb_substrthen counts it from the end of the string. Excel's docs say "If num_chars is greater than the length of text, RIGHT returns all of text", and LibreOffice does the same. This PR clamps the offset at 0.I added two cases to the RIGHT data provider: one ASCII and one multibyte, where the length is exactly one more than the text. Both fail without the fix. The TextData function tests pass, and php-cs-fixer, phpcs, and phpstan are clean on the changed file.