Skip to content

Fix code_verifier token randomness - #10424

Open
ZenJediMind wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
ZenJediMind:oauth-hardening
Open

ZenJediMind wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
ZenJediMind:oauth-hardening

Conversation

@ZenJediMind

@ZenJediMind ZenJediMind commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #. No listed issue.

Description of the problem being solved:

code_verifier was not being generated with sufficient randomness according to https://www.pathofexile.com/developer/docs/authorization#grants. Now it is.

Steps taken to verify a working solution:

  • Unit tests were ran.
  • Logged into my account on a Windows machine.

Link to a build that showcases this PR:

N/A

Before screenshot:

N/A

After screenshot:

N/A

@Wires77 Wires77 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, but instead of FFI, I'd rather implement a function in PathOfBuilding-SimpleGraphic to avoid OS-specific code in the Lua scripts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants