Skip to content

Support nine reduced Vestigial implicit effects - #10433

Draft
mcagnion wants to merge 3 commits into
PathOfBuildingCommunity:devfrom
mcagnion:bugfix/vestigial-reduced-implicits
Draft

mcagnion wants to merge 3 commits into
PathOfBuildingCommunity:devfrom
mcagnion:bugfix/vestigial-reduced-implicits

Conversation

@mcagnion

@mcagnion mcagnion commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

Some reduced Vestigial implicits are not recognized, while others lose their reduced magnitude or trigger probability before reaching the final calculations.

  • Support reduced effects from The Formless Flame, The Unblinking Eye, Ravenous Passion, The Apostate, Doryani's Prototype, The Ivory Tower and Entropic Devastation.
  • Apply Gamblesprint's reduced range to its saved roll and Asenath's Mark's trigger probability to its final rate.

For the captured poe.ninja Apostate export, combine its two marked Vestigial lines and adjust their implicit count to preserve both the 50% reduction and the following explicit modifiers.

Steps taken to verify a working solution:

  • Regression tests cover reduced values, wrapped item imports, source/slot selection and final calculations.
  • UI checks use unchanged poe.ninja exports for seven reduced implicit families.

Link to a build that showcases this PR:

Use the PoB import code on each character page. Screenshots use their 9 November exports.

Stat changes

Same character export and calculation settings on both versions. Deltas compare the base with this branch; percentages are relative to the base value.

Reduced implicit Stat Before After Delta
Formless Flame Armour 3,747 5,741 +1,994 (+53.22%)
Unblinking Eye Rolling Magma hit DPS 5,109,561.4 7,852,422.6 +2,742,861.2 (+53.68%)
Ravenous Passion, original 0 Rage Fireball hit DPS 18,227,096.8 18,227,096.8 0 (0.00%)
Ravenous Passion, assumed 20 Rage Fireball hit DPS 18,227,096.8 20,049,829.0 +1,822,732.2 (+10.00%)
Apostate Life 11,353 9,819 -1,534 (-13.51%)
Asenath's Mark Hydrosphere frozen autopulse DPS 9,798.4 9,798.4 0 (0.00%)
Asenath's Mark Hydrosphere trigger rate Not modelled 0.4/s Newly calculated
Doryani's Prototype Lightning hit taken 466.93 406.23 -60.70 (-13.00%)
Ivory Tower Chaos maximum hit 3,847 3,878 +31 (+0.81%)

Ravenous's export has zero Rage: the damage comparison uses the same illustrative 20 Rage input on both versions. Doryani's incoming lightning hit remains 1,774.07 at 3,682 armour. Ivory has only 15 unreserved mana. Apostate's life decreases because the wrapped reduction previously applied the full-strength conversion. Asenath's old manual cast rate is not a trigger-rate baseline; its frozen autopulse DPS does not change.

Screenshots

Item cards and breakdowns show this branch; Apostate also includes the base import.

Reduced Formless Flame

This branch: recognized Crown of Eyes implicit

At unchanged 215% overcapped fire resistance, Crown of Eyes contributes 107.5% increased armour.

Armour sources: Crown of Eyes contributes 107.5%

Reduced Unblinking Eye

This branch: recognized 50% conversion on The Gull

Total increased damage changes from 926% to 1,506% (+580 percentage points). Converted modifiers retain their original source labels; the Evasion and Energy Shield Mastery contributes 118.5% increased spell damage, without naming The Gull as the converter.

Spell damage sources after Unblinking's reduced conversion

Reduced Ravenous Passion

This branch: recognized 50% conversion on Malachai's Simula

The item view retains zero Rage. At the assumed 20 Rage, total more damage changes from 202% to 232% (+30 percentage points); the breakdown labels the 10% more spell damage as Rage.

Fireball more-damage sources, including 10% spell damage from Rage

Reduced Apostate

Before:

Base: Apostate's separate 50% continuation is unsupported

After:

This branch: both lines of Apostate's 50% conversion are recognized

The wrapped reduction is recognized on both lines. Energy shield remains replaced; the base-life breakdown lists the conversion contributions by slot.

Base life includes body armour, weapon and helmet ES-to-life conversion

Reduced Asenath's Mark

This branch: recognized 10% bow trigger on Fractal Thoughts

The helmet rotation applies the 10% chance to a 4.72/s source and produces 0.4/s, below the 3.03/s cooldown cap.

Hydrosphere trigger breakdown: 10% chance and helmet rotation produce 0.40/s

Reduced Doryani's Prototype

This branch: recognized 10% armour application on Blunderbore

At unchanged 3,682 armour, the lightning damage reduction row now shows 13%.

Lightning reduction breakdown attributes the 10% armour application to Blunderbore

Reduced Ivory Tower

This branch: recognized 50% chaos redirection on Chains of Command

Other damage types gain no mana redirection.

Chaos mana-redirection breakdown: 50% from Chains of Command, limited by 15 available mana

Risks/notes

Combining Apostate's 50% implicit with Reliquarian currently uses 100% conversion; whether the effects should add to 150% has not been verified in game.

Reduced Entropic Devastation and Gamblesprint are covered by regression tests but have not been validated on real character builds.

Existing unsupported shrine-duration and minion modifiers remain visible on The Gull and Chains of Command.

The full suite encounters the TestRareLike failure for That Which Was Taken's attainable modifier pool, also reproduced on the unchanged base.

Preserve partial magnitudes through the existing conversion, defence and
trigger calculations. Keep normal effects and saved Gamblesprint rolls,
and choose the strongest conversion or equal-level trigger source once.

Cover nine implicit families through item ingestion and final calculations.
Read the reduced-value continuation before accepting the full-strength
first line. Keep separately marked export lines from shifting the next
explicit modifier into the implicit list, and preserve item round trips.
Keep armour-source, hit-mitigation and pool observations beside their
assertions instead of collecting them for every test case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant