Repository navigation
Conversation
Preserve partial magnitudes through the existing conversion, defence and trigger calculations. Keep normal effects and saved Gamblesprint rolls, and choose the strongest conversion or equal-level trigger source once. Cover nine implicit families through item ingestion and final calculations.
Read the reduced-value continuation before accepting the full-strength first line. Keep separately marked export lines from shifting the next explicit modifier into the implicit list, and preserve item round trips.
Keep armour-source, hit-mitigation and pool observations beside their assertions instead of collecting them for every test case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Some reduced Vestigial implicits are not recognized, while others lose their reduced magnitude or trigger probability before reaching the final calculations.
For the captured poe.ninja Apostate export, combine its two marked Vestigial lines and adjust their implicit count to preserve both the 50% reduction and the following explicit modifiers.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Use the PoB import code on each character page. Screenshots use their 9 November exports.
Stat changes
Same character export and calculation settings on both versions. Deltas compare the base with this branch; percentages are relative to the base value.
Ravenous's export has zero Rage: the damage comparison uses the same illustrative 20 Rage input on both versions. Doryani's incoming lightning hit remains 1,774.07 at 3,682 armour. Ivory has only 15 unreserved mana. Apostate's life decreases because the wrapped reduction previously applied the full-strength conversion. Asenath's old manual cast rate is not a trigger-rate baseline; its frozen autopulse DPS does not change.
Screenshots
Item cards and breakdowns show this branch; Apostate also includes the base import.
Reduced Formless Flame
At unchanged 215% overcapped fire resistance, Crown of Eyes contributes 107.5% increased armour.
Reduced Unblinking Eye
Total increased damage changes from 926% to 1,506% (+580 percentage points). Converted modifiers retain their original source labels; the Evasion and Energy Shield Mastery contributes 118.5% increased spell damage, without naming The Gull as the converter.
Reduced Ravenous Passion
The item view retains zero Rage. At the assumed 20 Rage, total more damage changes from 202% to 232% (+30 percentage points); the breakdown labels the 10% more spell damage as Rage.
Reduced Apostate
Before:
After:
The wrapped reduction is recognized on both lines. Energy shield remains replaced; the base-life breakdown lists the conversion contributions by slot.
Reduced Asenath's Mark
The helmet rotation applies the 10% chance to a 4.72/s source and produces 0.4/s, below the 3.03/s cooldown cap.
Reduced Doryani's Prototype
At unchanged 3,682 armour, the lightning damage reduction row now shows 13%.
Reduced Ivory Tower
Other damage types gain no mana redirection.
Risks/notes
Combining Apostate's 50% implicit with Reliquarian currently uses 100% conversion; whether the effects should add to 150% has not been verified in game.
Reduced Entropic Devastation and Gamblesprint are covered by regression tests but have not been validated on real character builds.
Existing unsupported shrine-duration and minion modifiers remain visible on The Gull and Chains of Command.
The full suite encounters the TestRareLike failure for That Which Was Taken's attainable modifier pool, also reproduced on the unchanged base.