Skip to content

Fix Flamewood totem limit scaling - #10441

Open
AdamZ-8113 wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
AdamZ-8113:fix/flamewood-totem-limit
Open

AdamZ-8113 wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
AdamZ-8113:fix/flamewood-totem-limit

Conversation

@AdamZ-8113

Copy link
Copy Markdown
Contributor

Fixes #10440

Description of the problem being solved:

Flamewood's damage can use the wrong maximum totem count in PoB. For example, a Searing Bond build with a maximum of 10 totems shows Conjoined Spire's damage bonus as if the maximum were only 2.

This change makes Flamewood use the linked totem skill's maximum count.

Steps taken to verify a working solution:

  • Checked Searing Bond with Flamewood, with a maximum of 10 totems. PoB used 10 for Flamewood's damage and area calculations after the change.
  • Manually setting the number of summoned totems in config tab is still used to override max count for nodes like Ritual of Awakening
  • Ran the test suite (TWWT fails still, known issue)
  • I did not verify the in-game behavior, but I believe it's correct based on the wording of the notables.

Link to a build that showcases this PR:

https://pob.codes/b/-L5uttRsf_a

Before screenshot:

image

After screenshot:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flamewood Support doens't take additional maximum totems from skill gem/Foulborn The Searing Touch into account

1 participant