Repository navigation
Add Wickerman item data and character import support - #10455
AdamZ-8113 wants to merge 6 commits into
Conversation
|
Added support for pasting Viscera items. |
Hand-merged from PathOfBuildingCommunity#10455 (read-only fetch) on top of 10419 and 10451; applied cleanly, ModCache unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
| end | ||
|
|
||
| local rarityMap = { [0] = "NORMAL", "MAGIC", "RARE", "UNIQUE", [9] = "RELIC", [10] = "RELIC" } | ||
| local rarityMap = { [0] = "NORMAL", "MAGIC", "RARE", "UNIQUE", [9] = "RELIC", [10] = "RELIC", [15] = "NORMAL" } |
There was a problem hiding this comment.
Is there a particular reason to duplicate [0] ("NORMAL")
There was a problem hiding this comment.
The API response uses NORMAL with a new frameType
"rarity": "Normal",
"frameType": 15,
"frameTypeId": "Viscera"
I just followed what I thought the existing pattern was.
| for _, name in pairs(itemTypes) do | ||
| processTemplateFile(name, "Bases/", "../Data/Bases/", directiveTable) | ||
| end | ||
| processTemplateFile("wickerman", "Bases/", "../Data/Bases/", directiveTable) |
There was a problem hiding this comment.
Potentially add to itemTypes, you'd then benefit from the above loop
There was a problem hiding this comment.
Makes sense, I'll submit a follow up commit for that.
| LoadModule("Data/Bases/" .. type)(data.itemBases) | ||
| end | ||
| -- Wickerman has base data only; no unique rarity or modifier ownership is assumed. | ||
| LoadModule("Data/Bases/wickerman")(data.itemBases) |
There was a problem hiding this comment.
similarly, could be introduced to itemTypes, although this one interacts with the baggage of loading unique data later down the line
There was a problem hiding this comment.
Seems easier to keep it separate, especially if we assume Wickerman isn't going core, but I'm open to either.
Description of the problem being solved:
This adds support for importing Viscera from a character into PoB. This adds their item definitions and imports them into the four Wickerman equipment slots, keeping their names and modifiers when saving, reopening or reimporting a character.
** Dependencies**
This only works with the OAuth import route which uses the Character API. Import by Account name doesn't work because the website character viewer doesn't currently expose this data.
The four captured viscera have been checked against live data. Other definitions come from the preview spreadsheet and remain provisional. Greater variants and the three Artificial Appendages have synthetic test coverage but still need live examples. Ravenous Skull's corpse-consumption recovery text is imported, but its effect isn't calculated yet.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: