Skip to content

Add Wickerman item data and character import support - #10455

Open
AdamZ-8113 wants to merge 6 commits into
PathOfBuildingCommunity:devfrom
AdamZ-8113:submit/wickerman-character-import
Open

AdamZ-8113 wants to merge 6 commits into
PathOfBuildingCommunity:devfrom
AdamZ-8113:submit/wickerman-character-import

Conversation

@AdamZ-8113

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

This adds support for importing Viscera from a character into PoB. This adds their item definitions and imports them into the four Wickerman equipment slots, keeping their names and modifiers when saving, reopening or reimporting a character.

** Dependencies**

This only works with the OAuth import route which uses the Character API. Import by Account name doesn't work because the website character viewer doesn't currently expose this data.

The four captured viscera have been checked against live data. Other definitions come from the preview spreadsheet and remain provisional. Greater variants and the three Artificial Appendages have synthetic test coverage but still need live examples. Ravenous Skull's corpse-consumption recovery text is imported, but its effect isn't calculated yet.

Steps taken to verify a working solution:

  • Imported all four attached viscera from a live character response and confirmed their slots, names and modifiers survived reimport and save/load.
  • Used three synthetic Artificial Appendages with different IDs and modifiers to check that reimport and save/load preserve them as separate items.
  • All 9 import tests passed.
  • Tested the combined setup with the PRs listed above: 694 tests passed
  • Compared in game character sheet against PoB and confirmed life and armour bonuses from my Viscera are working

Link to a build that showcases this PR:

Before screenshot:

image

After screenshot:

image

@AdamZ-8113

Copy link
Copy Markdown
Contributor Author

Added support for pasting Viscera items.

jclfocused added a commit to LaserFocused-ee/PathOfBuilding that referenced this pull request Nov 14, 2026
Hand-merged from PathOfBuildingCommunity#10455
(read-only fetch) on top of 10419 and 10451; applied cleanly, ModCache unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Comment thread src/Classes/ImportTab.lua
end

local rarityMap = { [0] = "NORMAL", "MAGIC", "RARE", "UNIQUE", [9] = "RELIC", [10] = "RELIC" }
local rarityMap = { [0] = "NORMAL", "MAGIC", "RARE", "UNIQUE", [9] = "RELIC", [10] = "RELIC", [15] = "NORMAL" }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason to duplicate [0] ("NORMAL")

@AdamZ-8113 AdamZ-8113 Nov 15, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API response uses NORMAL with a new frameType

"rarity": "Normal",
"frameType": 15,
"frameTypeId": "Viscera"

I just followed what I thought the existing pattern was.

Comment thread src/Export/Scripts/bases.lua Outdated
for _, name in pairs(itemTypes) do
processTemplateFile(name, "Bases/", "../Data/Bases/", directiveTable)
end
processTemplateFile("wickerman", "Bases/", "../Data/Bases/", directiveTable)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially add to itemTypes, you'd then benefit from the above loop

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I'll submit a follow up commit for that.

Comment thread src/Modules/Data.lua
LoadModule("Data/Bases/" .. type)(data.itemBases)
end
-- Wickerman has base data only; no unique rarity or modifier ownership is assumed.
LoadModule("Data/Bases/wickerman")(data.itemBases)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly, could be introduced to itemTypes, although this one interacts with the baggage of loading unique data later down the line

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems easier to keep it separate, especially if we assume Wickerman isn't going core, but I'm open to either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants