Repository navigation
libtinfo.so version update and logic fix - #19
Merged
Merged
Conversation
jithunnair-amd
approved these changes
Jan 19, 2023
jithunnair-amd
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Thanks for testing it, @jataylo!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR moves to use libtinfo.so.6 on ROCm5.3 and beyond and includes a logic fix in build_common.sh and build_libtorch.sh
https://github.com/pytorch/pytorch/actions/runs/3957589731/jobs/6779808516
pytorch/pytorch#92538
Branch tested on upstream: pytorch/builder@main...jataylo:builder:libtinfo_update_jataylo
This fixes the error message seen for ROCm5.3 eg. in https://ossci-raw-job-status.s3.amazonaws.com/log/10656518264:
We need the version-dependent switch because ROCm5.2 needs libtinfo.so.5, otherwise we get the following message when using libtinfo.so.6 for it:
/usr/bin/ld: /tmp/libtorch/lib/libamd_comgr.so: undefined reference to 'setupterm@NCURSES_TINFO_5.0.19991023'