Skip to content

libtinfo.so version update and logic fix - #19

Merged
jithunnair-amd merged 3 commits into
ROCm:mainfrom
jataylo:libtorch_fixes_jack
Jan 19, 2023
Merged

jithunnair-amd merged 3 commits into
ROCm:mainfrom
jataylo:libtorch_fixes_jack

Conversation

@jataylo

@jataylo jataylo commented Jan 19, 2023 •

Copy link
Copy Markdown

The PR moves to use libtinfo.so.6 on ROCm5.3 and beyond and includes a logic fix in build_common.sh and build_libtorch.sh

https://github.com/pytorch/pytorch/actions/runs/3957589731/jobs/6779808516
pytorch/pytorch#92538

Branch tested on upstream: pytorch/builder@main...jataylo:builder:libtinfo_update_jataylo

This fixes the error message seen for ROCm5.3 eg. in https://ossci-raw-job-status.s3.amazonaws.com/log/10656518264:

2023-01-15T10:02:53.3817808Z + g++ /builder/test_example_code/simple-torch-test.cpp -I/tmp/libtorch/include -I/tmp/libtorch/include/torch/csrc/api/include -D_GLIBCXX_USE_CXX11_ABI=1 -std=gnu++14 -L/tmp/libtorch/lib -Wl,-R/tmp/libtorch/lib -Wl,--no-as-needed -ltorch -ltorch_cpu -lc10 -o simple-torch-test
2023-01-15T10:03:08.1787744Z /usr/bin/ld: /tmp/libtorch/lib/libamd_comgr.so: undefined reference to `del_curterm@NCURSES6_TINFO_5.0.19991023'
2023-01-15T10:03:08.1789529Z /usr/bin/ld: /tmp/libtorch/lib/libamd_comgr.so: undefined reference to `setupterm@NCURSES6_TINFO_5.0.19991023'
2023-01-15T10:03:08.1790919Z /usr/bin/ld: /tmp/libtorch/lib/libamd_comgr.so: undefined reference to `tigetnum@NCURSES6_TINFO_5.0.19991023'
2023-01-15T10:03:08.1792336Z /usr/bin/ld: /tmp/libtorch/lib/libamd_comgr.so: undefined reference to `set_curterm@NCURSES6_TINFO_5.0.19991023'
2023-01-15T10:03:08.1793470Z collect2: error: ld returned 1 exit status
2023-01-15T10:03:08.1928694Z ##[error]Process completed with exit code 1.

We need the version-dependent switch because ROCm5.2 needs libtinfo.so.5, otherwise we get the following message when using libtinfo.so.6 for it:
/usr/bin/ld: /tmp/libtorch/lib/libamd_comgr.so: undefined reference to 'setupterm@NCURSES_TINFO_5.0.19991023'

@jithunnair-amd jithunnair-amd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for testing it, @jataylo!

@jithunnair-amd
jithunnair-amd merged commit 7a44689 into ROCm:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants