Repository navigation
Default UV scale for new brushes; cylinders keep their surfaces' UVs (#270) - #310
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #270.
Changes
ChiselEditorSettings.DefaultUVScale, 1 by default). Every surface of a new brush starts with that UV scale, keeping its translation and rotation.ChiselDefaultUVScale.GiveTois called wherever a new generator gets the active material: the create menu and the placement tools.Tests
ChiselDefaultUVScaleTests: a new brush gets the scale on every surface, giving it again doesn't compound, and a scale of 1 leaves the surfaces as they are.ChiselCylinderUVTests: the generated mesh and the brush built in the editor are laid out as before, a surface's own UVs are kept when the cylinder changes, a scaled side keeps the sides in line, and a cylinder saved before looks the same.