Repository navigation
Conversation
|
This PR changes the test suite by +21 test cases (browser +1, unit +19, server +1). Keep tests that would fail for a real reason, and test logic below the UI where it can be. See Testing. |
Reopened from pingdotgg#32052 and squashed onto current main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wSedlacek
force-pushed
the
t3/ssh-open-terminal
branch
from
November 14, 2026 23:54
29d565e to
025fe1c
Compare
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Other scenariosAll 64 scenario measurements match All 64 scenario measurements
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Remote Open in could open editors over SSH, but Terminal stayed local-only. Users working against an SSH or advertised Tailscale/mDNS host still needed a separate terminal to SSH in and cd to the project.
Change
When Open in runs against a remote SSH alias or advertised Tailscale/mDNS host, Terminal (desktop) opens a local system terminal that SSHs into that host and starts in the project folder. It reuses the same remote-open host resolution as Cursor/VS Code deep links; Terminal stays hidden in plain web remote sessions where a local terminal cannot be spawned. Documents the remote behavior in the terminal guide.
Stacked on pingdotgg#30656 (includes that PR until it lands; the SSH-only commits are
feat(desktop): Open in Terminal SSHs into remote hostsand the follow-up harden fix).Scope and approval
Focused extension of Open in Terminal from pingdotgg#30656: remote SSH launch on desktop only, no new settings surface.
Screenshots
Remote Open in menu with Terminal selected. Choosing it opens a local system terminal that SSHs into the remote host and cds to the project folder.
Verification
vp run check:changedpassed after the harden follow-up, including focused tests for--before the SSH destination, leading-dash host rejection,/bin/sh -cremote command shape, Windows Terminal semicolon escaping and new-window argv, cmd%escaping, and xfce4-terminal-x. No live SSH host, Windows Terminal, Xfce, or fish/csh login-shell session was run.Test plan
;or%NAME%still cds correctly on WindowsMade with Cursor
🤖 Generated with Claude Code