Repository navigation
Stop calling Node 20 actions from rails-ci #patch - #44
Open
OutlawAndy wants to merge 1 commit into
Open
OutlawAndy wants to merge 1 commit into
OutlawAndy wants to merge 1 commit into
Conversation
test-cleanup@v1 still used actions/upload-artifact@v4, and the Project Stats step used actions/github-script@v7. Both target Node 20, so every run printed GitHub's Node 20 deprecation warning plus Node's punycode and url.parse() warnings. Call test-cleanup and test-runtime-analyzer at @V3 (same inputs) and github-script at @v9. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every
rails-ci.ymlrun prints:(seen on RoleModel/compass CI after it moved to
rails-ci.yml@v3).actions/upload-artifact@v4isn't referenced directly. It comes fromRoleModel/actions/test-cleanup@v1:rails-ci.yml,linting-and-non-system-testsandsystem-testsstill pin this repo's own sub-actions to the oldv1tag, and that tag'stest-cleanupusesupload-artifact@v4.actions/github-script@v7publishes the Project Stats check.Changes
test-cleanupandtest-runtime-analyzerare called at@v3in all three places. Betweenv1andv3their inputs are the same; the only behavior change istest-cleanup'supload-artifact@v4→@v7, whichv3already uses for screenshots.actions/github-script@v7→@v9. v9's breaking change is that scripts can'trequire('@actions/github'). The Project Stats script only uses the built-ingithubandcontext, so it's unaffected. v8+ needs runner 2.327.1, and runners already run these actions on Node 24.Verification
The three files still parse as YAML. I haven't run a caller against this branch. The changes are version pins whose targets are already in use (
upload-artifact@v7inv3).🤖 Generated with Claude Code