Skip to content

Stop calling Node 20 actions from rails-ci #patch - #44

Open
OutlawAndy wants to merge 1 commit into
mainfrom
fix/node20-action-deprecations
Open

OutlawAndy wants to merge 1 commit into
mainfrom
fix/node20-action-deprecations

Conversation

@OutlawAndy

Copy link
Copy Markdown
Member

Why

Every rails-ci.yml run prints:

Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/github-script@v7, actions/upload-artifact@v4.
(node) [DEP0040] DeprecationWarning: The `punycode` module is deprecated.
(node) [DEP0169] DeprecationWarning: `url.parse()` behavior is not standardized ...

(seen on RoleModel/compass CI after it moved to rails-ci.yml@v3).

  • actions/upload-artifact@v4 isn't referenced directly. It comes from RoleModel/actions/test-cleanup@v1: rails-ci.yml, linting-and-non-system-tests and system-tests still pin this repo's own sub-actions to the old v1 tag, and that tag's test-cleanup uses upload-artifact@v4.
  • actions/github-script@v7 publishes the Project Stats check.

Changes

  • test-cleanup and test-runtime-analyzer are called at @v3 in all three places. Between v1 and v3 their inputs are the same; the only behavior change is test-cleanup's upload-artifact@v4 → @v7, which v3 already uses for screenshots.
  • actions/github-script@v7 → @v9. v9's breaking change is that scripts can't require('@actions/github'). The Project Stats script only uses the built-in github and context, so it's unaffected. v8+ needs runner 2.327.1, and runners already run these actions on Node 24.
  • CHANGELOG entry for v3.13.4.

Verification

The three files still parse as YAML. I haven't run a caller against this branch. The changes are version pins whose targets are already in use (upload-artifact@v7 in v3).

🤖 Generated with Claude Code

test-cleanup@v1 still used actions/upload-artifact@v4, and the Project
Stats step used actions/github-script@v7. Both target Node 20, so every
run printed GitHub's Node 20 deprecation warning plus Node's punycode and
url.parse() warnings. Call test-cleanup and test-runtime-analyzer at @V3
(same inputs) and github-script at @v9.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant