Migration : Frontend by Nazi-pikachu · Pull Request #77 · Samagra-Development/yaus

Nazi-pikachu · 2023-07-05T18:00:20Z

Description

To migrate the frontend from previous seperate repo to the main repo

Changes Made

Generated a react-app using nx

Related Issues

Testing Instructions

Follow the setup readme
run nx serve frontend

Screenshots (if applicable)

Current output

Additional Notes

Its an intial PR in which the frontend code has been migrated to frontend app follow test instructions to know how to run the frontend.

gitguardian · 2023-07-05T18:13:26Z

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
-	Generic Password	`caec5c4`	apps/frontend/src/app/apis/index.js	View secret
-	Generic Password	`caec5c4`	apps/frontend/src/app/apis/index.js	View secret
-	Generic Password	`7cc3d87`	apps/frontend/src/app/apis/index.js	View secret
-	Generic Password	`7cc3d87`	apps/frontend/src/app/apis/index.js	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

yuvrajsab · 2023-07-06T08:08:45Z

+import { useNavigate } from "react-router-dom";
+
+function Protect(props) {
+  let Cmp = props.Cmp;


use proper names for variables.

yuvrajsab · 2023-07-06T08:09:21Z

+  email: "test@gmail.com",
+  password: "test@123",
+};
+const baseUrl = "https://fa.chakshu-rd.samagra.io/api";


access these from an env or app constants.

@Nazi-pikachu

yuvrajsab · 2023-07-06T08:09:55Z

+  console.log(
+    JSON.stringify({
+      registration: {
+        applicationId: "650c50b5-eae9-442e-88de-fc36be10a21b", // TO DO : Change this to env variable
+      },
+      user: {
+        name: "test",
+        email: "test@gmail.com",
+        password: "test@123",
+      },
+    })
+  );


remove unnecessary logs

yuvrajsab · 2023-07-06T08:11:48Z

+@media (min-width: 1024px) {
+  .layout-dashboard .ant-layout-footer {
+    margin: 0 0 20px 20px;
+  }
+  .layout-dashboard .ant-layout-sider.sider-primary {
+    margin: 20px 0 0 20px;
+    padding: 13px 20px;
+    height: calc(100vh - 20px);
+  }
+  .layout-dashboard .ant-layout {
+    width: auto;
+    flex-shrink: 1;
+    margin-left: 270px;
+  }
+  .layout-dashboard .header-control .sidebar-toggler {
+    display: none;
+  }
+}
+
+@media (min-width: 768px) {
+  .layout-dashboard .ant-layout-header {
+    margin: 10px 20px;
+  }
+  .layout-dashboard .header-control {
+    margin-top: 0;
+  }
+  .layout-dashboard .header-control .header-search {
+    margin: 0 7px;
+  }
+  .layout-dashboard .header-control .btn-sign-in span {
+    display: inline;
+  }
+  .profile-nav-bg {
+    margin-top: -87.8px;
+  }
+  .card-profile-head {
+    margin: -53px 24px 24px;
+  }
+}
+
+@media (min-width: 992px) {
+  .card-billing-info.ant-card .ant-card-body {
+    display: flex;
+  }
+  .layout-dashboard-rtl {
+    overflow: auto;
+  }
+  .layout-dashboard-rtl .ant-layout-sider.sider-primary {
+    margin: 20px 20px 0 0;
+    height: calc(100vh - 20px);
+  }
+  .layout-dashboard-rtl .ant-layout-sider.sider-primary {
+    right: 0;
+    left: auto;
+  }
+  .layout-dashboard-rtl .ant-layout-sider.sider-primary {
+    right: 0;
+    left: auto;
+  }
+  .layout-dashboard-rtl .ant-layout {
+    margin-right: 270px;
+    margin-left: 0;
+  }
+  .layout-dashboard-rtl .ant-layout-footer {
+    margin: 0 20px 20px 0;
+  }
+}


min widths should come in ascending order. e.x 768 then 992 then 1024.

yuvrajsab · 2023-07-06T08:12:09Z

+    margin-top: -87.8px;
+  }
+  .card-profile-head {
+    margin: -53px 24px 24px;


negative margins should be avoided.

yuvrajsab · 2023-07-06T08:13:28Z

+  const [state, setState] = useState({
+    userID: "0fe6ff38-fc46-11ec-b939-0242ac120001",
+    url: "",
+    project: "0fe6ff38-fc46-11ec-b939-0242ac120002",
+    customHashId: nanoid(6),
+    titleImage: "",
+    urlImg: "",
+    description: "",


should not be hardcoded like that.

yuvrajsab · 2023-07-06T08:14:44Z

+                    count={12}
+                    style={{ paddingTop: "10px" }}
+                  />
+                  &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;


find another way to add spaces. remove this

Nazi-pikachu · 2023-07-12T10:16:04Z

Progress on this PR Till now

Frontend Migrated to monorepo
Migrated to react-router-dom v6
Fixed few pages for responsiveness
Refactored the entire Frontend as per the standards
Deployed to vercel to ease tracking

Shruti3004 · 2023-07-17T04:55:24Z

+  email: "test@gmail.com",
+  password: "test@123",
+};
+const baseUrl = "https://fa.chakshu-rd.samagra.io/api";


@Nazi-pikachu

Shruti3004 · 2023-07-17T04:56:08Z

@@ -0,0 +1,21 @@
+import React, { useEffect } from "react";


@Nazi-pikachu can we move this in folder name utils

Shruti3004 · 2023-07-17T04:56:35Z

+  return (
+    <div className="App">
+      <Routes>
+        <Route path="/sign-up" element={<SignUp />} />


@Nazi-pikachu please create the constants folder for all the routes

Shruti3004 · 2023-07-17T04:57:01Z

@@ -0,0 +1 @@
+/* Your styles goes here. */


Delete this file

Shruti3004 · 2023-07-17T04:57:42Z

@@ -0,0 +1,30 @@
+import { piedata } from "app/assets/constants/mockData";


@Nazi-pikachu please take the constants and styles folder out of it

Generated frontend react-app

f1a09ea

Nazi-pikachu marked this pull request as draft July 5, 2023 18:01

Migration : Frontend

caec5c4

Nazi-pikachu added 2 commits July 6, 2023 00:04

Added mockData to remove server dependency

043e85f

feat(relative-path): added the files for relative imports

7ca87fe

yuvrajsab reviewed Jul 6, 2023

View reviewed changes

Nazi-pikachu added 3 commits July 10, 2023 01:50

Fix : SignIn and Dashboard Pages

7cc3d87

Fix : Pages (Mobile responsive)

f47df14

Refactor: Shifted Pages & Components to Index.js

a9098df

Shruti3004 requested changes Jul 17, 2023

View reviewed changes

Refactor : constant routes and re-structuring

e77da98

Nazi-pikachu requested a review from Shruti3004 July 18, 2023 06:18

Shruti3004 approved these changes Jul 18, 2023

View reviewed changes

Shruti3004 marked this pull request as ready for review July 18, 2023 13:45

Shruti3004 merged commit 439aaef into Samagra-Development:master Jul 18, 2023

Nazi-pikachu mentioned this pull request Jul 19, 2023

Refactor dummy icons : Frontend-YAUS #76

Closed

Nazi-pikachu mentioned this pull request Sep 15, 2023

[C4GT] Frontend and Deep Linking #52

Open

17 tasks

		@@ -0,0 +1,30 @@
		import { piedata } from "app/assets/constants/mockData";

Conversation

Nazi-pikachu commented Jul 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes Made

Related Issues

Testing Instructions

Screenshots (if applicable)

Additional Notes

Uh oh!

gitguardian Bot commented Jul 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Nazi-pikachu commented Jul 12, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Nazi-pikachu commented Jul 5, 2023 •

edited

Loading

gitguardian Bot commented Jul 5, 2023 •

edited

Loading