Skip to content

refactor: remove the remaining Lambda layer machinery - #43

Open
BGarber42 wants to merge 1 commit into
mainfrom
refactor/remove-layer-references
Open

BGarber42 wants to merge 1 commit into
mainfrom
refactor/remove-layer-references

Conversation

@BGarber42

Copy link
Copy Markdown
Contributor

The repository publishes OCI images only, but the layer era still left live configuration and dead assets.

Removed

  • layer-publishable-only from the matrix action and the release workflow (the generator no longer implements it).
  • The unused publicize workflow input, whose description still promised layer permissions.
  • The lambda and release manifest blocks, their defaults, validation and environment variables (LAYER_NAME, LAYER_DESCRIPTION, COMPATIBLE_RUNTIMES, BUCKET_BASE_NAME, RELEASE_REGIONS, S3_KEY_PREFIX).
  • package_name / PACKAGE_NAME / PACKAGE_PATH, left over from the zip artifact. ensure_runtime_built now checks the payload manifest instead of a file that is never produced.
  • Per-runtime examples/sam/ templates, Makefiles and examples/sls/ applications. The handler and event the container smoke test needs moved to examples/local/.
  • requirements-ci.txt (AWS SAM CLI), the SAM-related ignore rules and the SAM section of CONTRIBUTING.md.
  • The layer postmortem in DELIVERY.md; the delivery contract is now described directly.
  • Dead test helpers for the AWS layer publishing API and stale layer-contract comments.

Renamed

  • LAYER_ROOT → PAYLOAD_ROOT, layer_root → payload_root, CONTAINER_LAYER_ROOT → CONTAINER_PAYLOAD_ROOT, and the build-context directory layer/ → payload/.
  • SLIM_LAYER → SLIM_PAYLOAD, slim_layer → slim_payload.
  • examples/sam/{hello,events} → examples/local/{hello,events}; the manifest's local_testing block keeps only event, code_uri, handler and function_name.

Verification

  • pytest tools/runtime_lib/tests -q — 209 passed
  • bash -n over every tools/bin/* — pass
  • runtime_manifest.py validate and check --runtime pypy311 --arch x86_64 — pass
  • Every runtime_manifest.py env for all runtimes and both architectures — pass
  • All workflow/action YAML parses
  • 109 files changed, 145 insertions / 1,304 deletions

Note

The remaining layer mentions are OCI/BuildKit layers, not Lambda layers.

The repository publishes OCI images only, but the layer era still left live configuration: the workflow layer-publishable filter, the lambda/release manifest blocks, package_name and PACKAGE_PATH, the SAM/Serverless deployment examples, and the LAYER_ROOT/LAYER_NAME environment names.

Drop the lambda and release defaults and their validation, rename the staging tree to payload (PAYLOAD_ROOT, payload_root, context/payload), remove the unused publicize input and package fields, and keep only the local hello/event assets the container smoke test needs under examples/local/. The SAM section, requirements-ci.txt and its ignore rules are gone; docs now describe the image path only.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant