You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Moved "track email delivered and opened" to new automations interface - #32573
No actionable comments were generated in the recent review.
Walkthrough
Email delivery and open tracking moves from the legacy repository to the v2 automations API and repository. The v2 repository records timestamps while preserving the earliest values, locks recipients without a recorded open, and increments revision open counts. The analytics processor and tests use the updated tracking data type and API.
Possibly related PRs
TryGhost/Ghost#32569: Changes the same tracking behavior and transaction; this PR relocates that behavior to the v2 API and repository.
TryGhost/Ghost#30625: Filters generic bot opens before event-map creation; this PR records opens from that map.
Suggested labels: migration
Suggested reviewers: troyciesco, cmraible
Merge Risk: Minimal · up to dd18a
No material regression has been identified in the migrated email delivery and open tracking path; the PR is ready for normal merge checks.
Pre-merge checks: 7
Check name
Status
Explanation
Title check
The title names the moved method, 'track email delivered and opened', and the new automations interface. The changeset moves that method from the legacy repository to automationsApi2, so the title mat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Type-Safe Boundaries
The PR does not introduce a type-safety boundary defect. It moves the existing tracking logic from the legacy repository into automations-api-2.ts; the Mailgun event normalization and batch processi…
New Files Are Typescript
The pull request adds no files. All changed source files use the .ts extension, so it does not add a .js, .jsx, .cjs, or .mjs source file.
Tooling Ownership
The pull request changes only automations implementation files and tests under ghost/core and ghost/test. It does not add or modify scripts, tools, shared configuration, build inputs, shipped …
Description check
The description says the PR moves another function to the new automations interface, referring to the "track email delivered and opened" method. The changeset does exactly that: it adds trackEmailDeli…
Full details: Title check
Explanation
The title names the moved method, 'track email delivered and opened', and the new automations interface. The changeset moves that method from the legacy repository to automationsApi2, so the title matches the main change.
Full details: Type-Safe Boundaries
Explanation
The PR does not introduce a type-safety boundary defect. It moves the existing tracking logic from the legacy repository into automations-api-2.ts; the Mailgun event normalization and batch processing path already existed, and the changed processor only changes the imported TypeScript type. The new database row read in lockNotYetOpenedEmailRecipients uses a Zod schema. No new unchecked as, any, @ts-ignore, or @ts-nocheck appears in production changes, and the new tracking type does not duplicate a Zod-described shape.
Full details: Tooling Ownership
Explanation
The pull request changes only automations implementation files and tests under ghost/core and ghost/test. It does not add or modify scripts, tools, shared configuration, build inputs, shipped commands, or other tooling paths. The tooling-ownership criteria therefore do not apply, and no placement or execution problem is introduced.
Full details: Description check
Explanation
The description says the PR moves another function to the new automations interface, referring to the "track email delivered and opened" method. The changeset does exactly that: it adds trackEmailDeliveredAndOpened to automationsApi2, removes it from the legacy repository, and updates the related tests. The description is related to the changes, so this check passes. It is brief, but it names the migration and links the tracking issue, which is enough for this lenient check.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.
Review new or changed service boundaries for explicit dependency ownership, deterministic/idempotent initialisation, boot ordering, transaction and event semantics, cache coherence, and restart/multi-instance safety.
Review lens: "where does this data become trusted?" Boundary data (HTTP input, external API/SDK responses, env/config, DB/filesystem reads, queue/webhook/event payloads) is `unknown` until validated — Zod by default.
Applicability reference: AGENTS.md: # AGENTS.md Start with: [Testing](docs/contributing/testing.md) Source excerpt: Put tests as close as possible to the code and behavior under test: **Unit tests** cover a function, compo...
Applicability reference: AGENTS.md: # AGENTS.md **Ghost Core:** use the [server map](docs/codebase/monorepo-structure.md#ghost-core) and read the [services guide](ghost/core/server/services/README.md) before Source excerpt...
Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci
❌ Patch coverage is 87.80488% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.00%. Comparing base (ef4edea) to head (dd18aa4).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
towards https://linear.app/ghost/issue/NY-1704
Moves another function to the new automations interface. No user impact expected.