Repository navigation
feat(config): default MiniMax presets to M3.1 Flash - #421
Open
octo-patch wants to merge 1 commit into
Open
octo-patch wants to merge 1 commit into
octo-patch wants to merge 1 commit into
Conversation
PR Summary by QodoDefault MiniMax presets to M3.1 Flash and refresh China endpoints
AI Description
Diagram
High-Level Assessment
Files changed (10)
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Code Review by Qodo
1. Chinese provider guide breaks language rule
|
![qodo-free-for-open-source-projects[bot]](https://avatars.githubusercontent.com/in/1068000?s=60&v=4){kind=small}
Comment on lines
+153
to
+165
| - 🎯 MiniMax-M3.1-Flash（默认）和 MiniMax-M3 | ||
| - 💡 两个模型均支持 1,000,000 tokens 上下文窗口 | ||
| - 🔧 Claude Code 使用 Anthropic API，Codex 使用 Responses API | ||
|
|
||
| **配置信息**： | ||
| - **Claude Code Base URL**: `https://api.minimax.io/anthropic` | ||
| - **Codex Base URL**: `https://api.minimax.io/v1` | ||
| - **中国区（`minimax-cn`）**: `https://api.minimax.cn/anthropic` / `https://api.minimax.cn/v1` | ||
| - **认证方式**: `auth_token` | ||
| - **Claude Code 默认模型**: `MiniMax-M3`（主力）、`MiniMax-M2.7-highspeed`（高速） | ||
| - **Claude Code 默认模型**: `MiniMax-M3.1-Flash`（主力）、`MiniMax-M3`（Haiku 角色） | ||
| - **Codex 默认模型**: `MiniMax-M3.1-Flash` | ||
|
|
||
| 显式指定的模型和 URL（包括已保存的旧模型配置）保持不变。ZCF 生成客户端配置，thinking 历史、工具调用和图片请求由客户端处理。Flash 不支持禁用 thinking 或 `none` effort。 |
There was a problem hiding this comment.
1. Chinese provider guide breaks language rule 📘 Rule violation ⚙ Maintainability
The modified Chinese and Japanese provider guides add non-English Markdown, and the Chinese troubleshooting guide changes an inline endpoint comment to Chinese, all outside the README_zh-CN exception. Future contributors must maintain provider guidance in unsupported documentation languages, while developers reading the troubleshooting guide must interpret an endpoint note unavailable in English.
Agent Prompt
## Issue description
The modified Chinese and Japanese provider guides contain new non-English Markdown, and the troubleshooting guide contains a Chinese inline endpoint comment. These changes are outside README_zh-CN, the stated exception to the repository's English documentation requirement.
## Fix Focus Areas
- docs/zh-CN/advanced/api-providers.md[153-165]
- docs/ja-JP/advanced/api-providers.md[153-165]
- docs/zh-CN/advanced/troubleshooting.md[158-158]
## Recommended Fix
Replace the newly added Chinese and Japanese provider documentation with English text, or move the localized content to an explicitly supported localization workflow rather than modifying these Markdown guides directly. Replace the changed Chinese endpoint comment with an English comment that identifies the MiniMax China endpoint.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason: New MiniMax configurations still select M3/M2.7, and the China preset uses the previous regional hostname. This refresh makes MiniMax-M3.1-Flash the default while preserving explicit model and endpoint overrides.
Description
api.minimax.cnChina endpoints for Anthropic and Responses APIs.Official contracts: global Responses, China Responses, China Anthropic.
Type of Change
Testing
Using repository-pinned pnpm 10.17.1 and a frozen lockfile:
pnpm lint: passed.pnpm typecheck: passed.git diff --check: passed.1ba0726c564607e391a77c25fb8ddd1ea1b6b8ae: lint/typecheck and build/test:coverage steps passed on Linux, Windows, and macOS. The queued local build was canceled before starting after CI provided this validation.The full suite and coverage thresholds were validated in CI, not repeated locally. The passing init-provider tests print warnings about a missing
mkdirSyncexport in their filesystem mock. ZCF generates configuration for external clients; it does not implement the inference SDK/HTTP boundary. Tool calls, thinking-history replay, streaming, and image payloads are therefore not wire-tested by this change. No paid inference was performed.Checklist