Repository navigation
feat(chat): accept user images on default lane (#596) - #614
Open
rishiiicreates wants to merge 1 commit into
Open
rishiiicreates wants to merge 1 commit into
rishiiicreates wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #596
normalizes user message content parts so the default lane accepts both chat completions image_url dicts and anthropic image base64 blocks on openai agents and claude-code/ engines.
for openai agents, anthropic base64 blocks get converted over to data url image_url payloads, and image_url dicts pass through directly. for claude-code/, data urls get unpacked into native anthropic image blocks, while remote https image urls fail fast with the suggested protocol lane exit since claude code cli only takes base64 images. assistant content is kept strictly string-only, and unknown part types or invalid urls reject eagerly.
added tests in test_local_chat.py and test_claude_code.py verifying the converted image parts make it to fake model and cli doubles intact, along with all the validation boundaries. full test suite passes locally.