Skip to content

Exclude Reprint from new pulls by default - #818

Open
adamziel wants to merge 2 commits into
codex/exclude-reprint-optionfrom
codex/exclude-reprint-by-default
Open

adamziel wants to merge 2 commits into
codex/exclude-reprint-optionfrom
codex/exclude-reprint-by-default

Conversation

@adamziel

@adamziel adamziel commented Sep 16, 2026 •

Copy link
Copy Markdown
Collaborator

New pulls omit the source Reprint plugin, connection options, and activation entries by default, so the destination does not inherit migration credentials or point at missing Reprint files.

Stacked on #817, which builds on #821. This changes the default for new state directories only. Existing state keeps its saved choice, including state written before the option existed. --include-reprint still opts out.

The CLI help and README describe the new default. Existing whole-site copy tests explicitly select --include-reprint; the exclusion tests check the new default and both flags. Hand-written preflight fixtures now report that they run without the WordPress plugin, just as the current standalone server does.

Testing

Pull with a fresh state directory and no Reprint flag. Check that Reprint files, connection options, and activation entries are absent. Repeat with --include-reprint and confirm they remain. Reuse a state directory created with inclusion selected and confirm it still includes Reprint.

@github-actions

github-actions Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Pull pipeline performance — large-directory

Site: large-directory · 2,000+ plus targeted file-transfer scenarios files · 10,000 posts · 25,000 postmeta · PHP 8.5.10

trunk baseline unavailable — showing PR numbers only.

Stage Wall time Resume attempts Status Details
playground-sqlite-db-pull 3.14 s 1 ✓
MetricsPR:
condition=db-pull in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=lexer
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=selected
playground-sqlite-db-apply 24.53 s 1 ✓
MetricsPR:
condition=db-apply to SQLite in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=parser
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=verified
native_ast=WP_MySQL_Native_Parser_Node
sqlite_driver_parser=verified
url-rewrite-html 221 ms 1 ✓
MetricsPR:
rows=128
input_MiB=0.29
MiB_per_second=1.3
sample_ms=224.9, 221.2, 222, 220.7, 220.8
peak_MiB=24
url-rewrite-style-elements 56 ms 1 ✓
MetricsPR:
rows=128
input_MiB=0.32
MiB_per_second=5.7
sample_ms=58.1, 56.5, 56.2, 56.4, 56.5
peak_MiB=12
url-rewrite-style-large-value 726 ms 1 ✓
MetricsPR:
rows=1
input_MiB=0.65
MiB_per_second=0.89
sample_ms=732.4, 713.7, 714, 730.2, 725.8
peak_MiB=12
url-rewrite-blocks-literal-urls 75 ms 1 ✓
MetricsPR:
rows=128
input_MiB=0.65
MiB_per_second=8.75
sample_ms=76.1, 75.2, 73.9, 74.4, 74.7
peak_MiB=24
url-rewrite-blocks-nested-html 78 ms 1 ✓
MetricsPR:
rows=128
input_MiB=0.82
MiB_per_second=10.59
sample_ms=79.8, 77, 77.7, 76.9, 77.5
peak_MiB=28
url-rewrite-blocks-repeated-urls 76 ms 1 ✓
MetricsPR:
rows=128
input_MiB=0.81
MiB_per_second=10.72
sample_ms=77.3, 74.6, 75.9, 75.6, 75
peak_MiB=28
url-rewrite-blocks-escaped-quotes 344 ms 1 ✓
MetricsPR:
rows=128
input_MiB=0.85
MiB_per_second=2.48
sample_ms=343.7, 343.8, 344.1, 344.8, 345.9
peak_MiB=40
url-rewrite-blocks-encoded-shortcodes 595 ms 1 ✓
MetricsPR:
rows=128
input_MiB=1
MiB_per_second=1.68
sample_ms=595.6, 593.4, 595.1, 595.3, 594.8
peak_MiB=54
url-rewrite-blocks-no-source-urls 2 ms 1 ✓
MetricsPR:
rows=128
input_MiB=0.67
MiB_per_second=349.31
sample_ms=2.9, 1.9, 1.9, 1.9, 2.1
peak_MiB=14
url-rewrite-serialized-options 43 ms 1 ✓
MetricsPR:
rows=128
input_MiB=0.38
MiB_per_second=8.93
sample_ms=43.8, 42.5, 42.6, 42.9, 42.3
peak_MiB=20
url-rewrite-selected-site-html 123 ms 1 ✓
MetricsPR:
rows=128
input_MiB=0.29
MiB_per_second=2.33
sample_ms=124.8, 121.9, 123.4, 123.1, 122.4
peak_MiB=24
url-rewrite-selected-site-style-elements 211 ms 1 ✓
MetricsPR:
rows=128
input_MiB=0.32
MiB_per_second=1.53
sample_ms=215.9, 212, 210.6, 211, 210.9
peak_MiB=24
url-rewrite-selected-site-style-large-value 594 ms 1 ✓
MetricsPR:
rows=1
input_MiB=0.65
MiB_per_second=1.09
sample_ms=597.4, 586.6, 594.5, 592.6, 594.6
peak_MiB=26
url-rewrite-selected-site-blocks-literal-urls 92 ms 1 ✓
MetricsPR:
rows=128
input_MiB=0.65
MiB_per_second=7.11
sample_ms=94.2, 92.5, 91.8, 91.9, 91.9
peak_MiB=30
url-rewrite-selected-site-blocks-nested-html 238 ms 1 ✓
MetricsPR:
rows=128
input_MiB=0.82
MiB_per_second=3.45
sample_ms=241.6, 239.3, 238.3, 238.2, 237.7
peak_MiB=40
url-rewrite-selected-site-blocks-repeated-urls 179 ms 1 ✓
MetricsPR:
rows=128
input_MiB=0.81
MiB_per_second=4.54
sample_ms=181.4, 178.4, 178.7, 178.5, 179.2
peak_MiB=28
url-rewrite-selected-site-blocks-escaped-quotes 241 ms 1 ✓
MetricsPR:
rows=128
input_MiB=0.85
MiB_per_second=3.54
sample_ms=242.7, 240.8, 241.5, 239, 239.2
peak_MiB=40
url-rewrite-selected-site-blocks-encoded-shortcodes 472 ms 1 ✓
MetricsPR:
rows=128
input_MiB=1
MiB_per_second=2.12
sample_ms=476, 470.7, 472.9, 472.3, 469
peak_MiB=54
url-rewrite-selected-site-blocks-no-source-urls 2 ms 1 ✓
MetricsPR:
rows=128
input_MiB=0.67
MiB_per_second=323.7
sample_ms=3, 2, 2, 2.1, 2.2
peak_MiB=14
url-rewrite-selected-site-serialized-options 43 ms 1 ✓
MetricsPR:
rows=128
input_MiB=0.38
MiB_per_second=8.78
sample_ms=44.5, 43.2, 43.3, 43.6, 43.3
peak_MiB=20
url-rewrite-selected-site-child-paths-style-elements 212 ms 1 ✓
MetricsPR:
rows=128
input_MiB=0.32
MiB_per_second=1.52
sample_ms=216.9, 209.8, 212.1, 211.7, 211.5
peak_MiB=24
url-rewrite-selected-site-child-paths-blocks-nested-html 244 ms 1 ✓
MetricsPR:
rows=128
input_MiB=0.82
MiB_per_second=3.37
sample_ms=246.3, 243.8, 244.2, 243.9, 244
peak_MiB=40
url-rewrite-selected-site-child-paths-blocks-repeated-urls 176 ms 1 ✓
MetricsPR:
rows=128
input_MiB=0.81
MiB_per_second=4.61
sample_ms=178.2, 175.5, 176, 173.9, 175.9
peak_MiB=28
Total 32.71 s

Numbers carry runner noise; treat single-run deltas as directional, not authoritative.

URL rows show the median of five samples, using the same inputs and PHP binary for both builds. Each sample starts with fresh caches and reuses one rewriter across 128 distinct values. Input generation and output checks are outside the timer. Every output must pass before a speed is reported.

📈 Trunk performance history — commit-by-commit timeline.

@adamziel
adamziel force-pushed the codex/exclude-reprint-by-default branch from 7064045 to b61e06a Compare September 16, 2026 16:43
@adamziel
adamziel force-pushed the codex/exclude-reprint-option branch from a8f2274 to dc9934e Compare September 17, 2026 09:49
@adamziel
adamziel force-pushed the codex/exclude-reprint-by-default branch from b61e06a to 273e782 Compare September 17, 2026 09:49

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant