Skip to content

Twenty Twenty: Let the button block font weight setting override the theme default - #14554

Open
irozum wants to merge 1 commit into
WordPress:trunkfrom
irozum:fix/58030-twentytwenty-button-font-weight
Open

irozum wants to merge 1 commit into
WordPress:trunkfrom
irozum:fix/58030-twentytwenty-button-font-weight

Conversation

@irozum

@irozum irozum commented Oct 20, 2026

Copy link
Copy Markdown

When a font weight (Appearance) is chosen on a Button block, Twenty Twenty never shows it, because the theme hard-codes font-weight: 600 on every .wp-block-button__link.

Changes

  • Add a font-weight: inherit rule for buttons whose wrapper carries an inline font-weight, mirroring the existing text-transform and letter-spacing rules.
  • Apply it to the front-end and editor stylesheets, plus their RTL counterparts.
  • The default button appearance is unchanged; letter case and letter spacing are out of scope.

Testing

  • Activate Twenty Twenty, add a Button block, and set Appearance to Bold, Light, etc. The weight now changes in the editor and on the front end.
  • Buttons with no font weight set still render at 600.
  • No automated test: this is a CSS-only change and there is no CSS test harness in core.

Trac ticket: https://core.trac.wordpress.org/ticket/58030

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5.5
Used for: Implementation and PR description.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for details.

🤖 Generated with Claude Code

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props irozum.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant