Repository navigation
Tests: Use assertWPError() in GD image editor tests - #14566
shail-mehta wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The assertion replacement preserves test behavior and error-code coverage, with no unresolved issues.
No open issues 🎉
What changed in this PR
Updates the GD image editor test to use WordPress’s dedicated error assertion.
Changes:
- Replaces
assertInstanceOf( 'WP_Error', … )withassertWPError(). - Preserves the existing error-code check; no production code changes.
| File | Description |
|---|---|
tests/phpunit/tests/image/editorGd.php |
Uses assertWPError() for invalid crop dimensions. |
Review effort: Balanced
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
lancewillett
left a comment
lancewillett
left a comment
There was a problem hiding this comment.
Reviewed with the unit-tests audit: the inherited assertWPError() helper delegates to the same type assertion, preserving the existing error-code checks and custom messages.
The affected class passed in three randomized single-site and three randomized multisite runs (seeds 14557, 14561, and 14568); every changed test executed. PHPCS passed, CI is green, and Copilot reviewed this head without findings.
AI review · gpt-6
Use the dedicated assertion helper for expected `WP_Error` results, preserving the existing test behavior and assertion messages. Developed in: #14566 Props shailu25. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@64648 602fd350-edb4-49c9-b593-d223f7449a82
|
PR #14566 landed in https://core.trac.wordpress.org/changeset/64648 |
Use the dedicated assertion helper for expected `WP_Error` results, preserving the existing test behavior and assertion messages. Developed in: WordPress/wordpress-develop#14566 Props shailu25. See #65819. Built from https://develop.svn.wordpress.org/trunk@64648 git-svn-id: http://core.svn.wordpress.org/trunk@63798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
What
Trac ticket: #65819
Replaces a generic
assertInstanceOf( 'WP_Error', … )assertion intests/phpunit/tests/image/editorGd.phpwith WordPress’s dedicatedassertWPError()assertion.Retains the existing error code check.
Test-only change.
Why
Dedicated assertion methods improve failure reporting by including the
WP_Errorcode and message automatically.How
assertInstanceOf( 'WP_Error', … )call forassertWPError()in invalid crop dimension coverageTesting instructions
Use of AI Tools