Repository navigation
Link: Add unit tests for paginate_comments_links() - #14703
Open
devmuhib009 wants to merge 1 commit into
Open
devmuhib009 wants to merge 1 commit into
devmuhib009 wants to merge 1 commit into
Conversation
Adds unit tests for `paginate_comments_links()` in `tests/phpunit/tests/link/paginateCommentsLinks.php`. Covers non-singular early return, plain and pretty permalinks, default echo behavior, returning array format when `type => 'array'`, and respecting the `cpage` query var. See #65819.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
huzaifaalmesbah
approved these changes
Oct 22, 2026
huzaifaalmesbah
left a comment
huzaifaalmesbah
left a comment
Member
There was a problem hiding this comment.
Thanks! Nice coverage for paginate_comments_links(), including the array type. LGTM.
AI Review: Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds unit tests for the
paginate_comments_links()function.Why
paginate_comments_links()had zero unit test coverage in WordPress Core.How
tests/phpunit/tests/link/paginateCommentsLinks.php.paginate_comments_links()returnsnullwhen not on a singular view.paginate_comments_links()echoes output by default.type => 'array'returns an array of link elements and avoids echoing.paginate_comments_links()respects thecpagequery var whencurrentis omitted.Trac ticket: https://core.trac.wordpress.org/ticket/65819