Repository navigation
Conversation
Add coverage for full and wildcard mime types, the comma-separated and array forms, removal of characters that are not allowed in a mime type, the values that return no clause, and the table alias. See #65819.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit tests for
wp_post_mime_type_where()intests/phpunit/tests/post/wpPostMimeTypeWhere.php. The function builds the SQL clause forpost_mime_typequeries inWP_Queryandwp_count_attachments(), and had no dedicated tests.Trac ticket: https://core.trac.wordpress.org/ticket/65819
What the tests cover
image,image/*,image/,image/**) givesLIKE 'image/%', and a full type gives=.+,.and-(image/svg+xml,application/vnd.ms-excel).'','%'and'%/%'return no clause, also when they follow another type, and so does an empty array.Test-only change.
Testing
All 19 test cases pass. Breaking the function in five ways (dropping
+from subtypes, removing the wildcard check, keeping quotes in the type, ignoring the table alias, replacing only a single*) makes 1 to 4 of them fail each time.Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code and Codex
Used for: Choosing the function, writing the tests, checking them against the function's real output, and auditing the tests and this description. I reviewed the tests and the results, and I take responsibility for the contribution.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.