Skip to content

Media: Cache post authors in query-attachments AJAX endpoint - #14714

Open
JDeepD wants to merge 1 commit into
WordPress:trunkfrom
JDeepD:fix-66363/prime-author-cache-attachment-ajax
Open

JDeepD wants to merge 1 commit into
WordPress:trunkfrom
JDeepD:fix-66363/prime-author-cache-attachment-ajax

Conversation

@JDeepD

@JDeepD JDeepD commented Oct 22, 2026 •

Copy link
Copy Markdown

Prime the author caches in wp_ajax_query_attachments() to reduce the number of database queries in the query-attachments admin-ajax endpoint.

Previously each distinct attachment author was loaded individually by wp_prepare_attachment_for_js(), costing two queries per author.

Trac ticket: https://core.trac.wordpress.org/ticket/66363

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Opus 5.5
Used for: Use for initial finding on the issue. The code change is tested and reviewed by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Prime the author caches in `wp_ajax_query_attachments()` to reduce the
number of database queries in the query-attachments admin-ajax endpoint.
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jdeep.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant