Skip to content

fix(s2): avoid invalid SVG radius diagnostics in ProgressCircle - #10845

Open
hamzabhulla wants to merge 3 commits into
adobe:mainfrom
hamzabhulla:fix/s2-progress-circle-svg-radius
Open

hamzabhulla wants to merge 3 commits into
adobe:mainfrom
hamzabhulla:fix/s2-progress-circle-svg-radius

Conversation

@hamzabhulla

@hamzabhulla hamzabhulla commented Oct 23, 2026 •

Copy link
Copy Markdown

Closes #10837

Summary

  • Replace the calc() SVG radius attributes on all three ProgressCircle circles with the CSS geometry r property.
  • Preserve the existing radius calculation.
  • Add a browser regression test covering all three circles.

Testing

  • The browser test check passed on the current PR commit.
  • The complete test suite has not been independently run locally.
  • The CircleCI lint check is failing and still needs investigation.

Accessibility

No accessibility semantics or public component APIs were intentionally changed.

AI assistance

AI assistance was used to investigate the issue and prepare the code and regression test. Please review the changes and test results before merging.

@hamzabhulla hamzabhulla changed the title Fix/s2 progress circle svg radius fix(s2): avoid invalid SVG radius diagnostics in ProgressCircle Oct 23, 2026
@reidbarber

Copy link
Copy Markdown
Member

Looks like the lint step is failing (Imports should be sorted alphabetically.). Also, be sure to sign the CLA.


for (let circle of circles) {
expect(circle.hasAttribute('r')).toBe(false);
expect(circle.style.getPropertyValue('r')).toBe('calc(50% - 0.125rem)');

@reidbarber reidbarber Oct 23, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I almost think a browser test is overkill, but we should at least assert the rendered geometry with getBBox() if anything.. Actually, let's just rely on existing chromatic tests for this, feel free to remove this test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[S2] ProgressCircle emits invalid SVG radius errors in WebKit and warnings in Firefox

2 participants