Skip to content

Enable settings to use warm cache - #67

Draft
Jaana Dogan (rakyll) wants to merge 1 commit into
mainfrom
warm-cache
Draft

Jaana Dogan (rakyll) wants to merge 1 commit into
mainfrom
warm-cache

Conversation

@rakyll

Copy link
Copy Markdown
Collaborator

No description provided.

@tomergee

Copy link
Copy Markdown
Collaborator

Heads-up from #77 (Substrate bump to f03327bd): once that lands this branch needs more than a rebase.

Suggest rebasing onto main after #77 merges and re-expressing the warm-cache settings in terms of preferredFidelity.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change sets onPause, onCommit and onResume.fromData in cmd/ate-env/manifest.go:306-310. The Substrate version on main does not have these fields, thus the branch does not compile after a rebase.

main sets preferredFidelity: MEMORY and keeps golden snapshots enabled by default (cmd/ate-env/manifest.go:422-427). The nearest equivalent of a data-only snapshot is SNAPSHOT_FIDELITY_VOLUMES with a durableDir workspace volume. Substrate has no replacement for a golden resume source for data.

The change also removes the empty-map check in prune for all keys (cmd/ate-env/manifest.go:341). That is a global change, not a warm-cache change.

Close this PR. If the VOLUMES level is necessary, open a new PR with a fidelity flag and an optional workspace volume.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants