Repository navigation
docs(rag): clarify Milvus batch size requirements - #87
Open
shuxiachai wants to merge 1 commit into
Open
shuxiachai wants to merge 1 commit into
shuxiachai wants to merge 1 commit into
Conversation
4 of 5 tasks
shuxiachai
marked this pull request as ready for review
October 16, 2026 06:53
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to agentscope-ai/agentscope#3341.
Add aligned English and Chinese notes beside the vector-store construction examples in the
2.0.11devRAG pages. The notes explain thatMilvusLiteStore.batch_sizemust be positive and that passing zero or a negative value raisesValueErrorwhen constructing the store.This accompanies agentscope-ai/agentscope#3343, which fixes negative batch sizes silently skipping nonempty inserts. The note is specific to
MilvusLiteStore; it does not change database algorithms or introduce a broader parameter-type policy.Only the two development-version RAG pages change. Published versions and navigation remain unchanged. The documentation base is
57dcb6f73eb9414949de72f657280c1d9362a68e.Validation
git diff --check: passed.npm exec --yes --package=mint@4.2.1006 -- mint validate: passed (success build validation passed, exit 0).Validation ran on Windows with Node 24.14.0 and npm 11.9.0. Node 22, browser preview, hosted checks, and deployment were not run. This is local documentation validation, not a claim of hosted CI success.
The corresponding SDK fix passed its selected offline vector-store suite: 29 tests and 9 subtests, with 13 existing Milvus integration tests skipped because optional dependencies are absent. This text-only documentation change does not add executable examples. Real Milvus integration was not tested locally; see the code PR for hosted CI results.
Related code and AI assistance
Companion code PR: agentscope-ai/agentscope#3343. Please coordinate documentation merge with the corresponding fix.
Codex assisted with text, translation, source verification, and validation. The contributor remains responsible for the final changes and for explaining them in review.