Skip to content

Fix native skill discovery paths and explain missing skills - #772

Open
sox8502 wants to merge 2 commits into
mainfrom
daniel/skill-detection
Open

sox8502 wants to merge 2 commits into
mainfrom
daniel/skill-detection

Conversation

@sox8502

@sox8502 sox8502 commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Cursor skills remain discoverable when XDG_CONFIG_HOME points elsewhere. Discovery, installation, and isolated launch preparation share the explicit native skill root. Antigravity accepts directory names when skill name metadata is absent. Customize adds collapsed, copyable detection details with checked paths and rejection reasons; existing precedence and native ownership remain intact.

Related to #685; these reproductions do not establish the reporter’s exact cause. Recursive discovery, additional plugin inventories, and cross-agent compatibility changes remain deferred.

Validation:

  • Rust formatting, Clippy, locked build, 1,286 unit tests and 19 CLI tests; 3 existing ignored tests.
  • UI production assets regenerated; typecheck, localization/style lint, and 428 UI tests passed.
  • macOS in-app checks: catalog, fallback, diagnostics/copy, refresh after addition/removal, and native Cursor and Antigravity invocations.
  • Windows Server 2025: locked build, 74 focused tests, baseline/candidate catalog comparison, diagnostic paths, and native Cursor and Antigravity invocations in project chats.
  • All final-head CI checks passed. Greptile reviewed 260a8c20 at 5/5 with no unresolved findings.
  • User-led functionality testing.

Tested: macOS 26.6.2 with Cursor CLI 2026.09.28-64d2043; Windows Server 2025 with Cursor CLI 2026.09.18-9a7762b; Antigravity CLI 1.4.6 on both. Windows 11 24H2, reported Cursor 3.17.8, and Antigravity 1.4.0 were unavailable and remain unverified. Screenshots and the action/result record are retained in /private/tmp/skill-detection-evidence/; video capture was unavailable.

@sox8502

sox8502 commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

@greptileai review

@greptile-apps

greptile-apps Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new actionable issues were found.

Summary

The PR separates native skill paths from session state and adds copyable discovery details.

  • Cursor skills stay discoverable when XDG redirects its state.
  • Antigravity can find skills whose metadata omits a name.
  • Customize explains which native skills it found or skipped.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Declared native skill roots] --> B[Skill discovery]
  A --> C[Skill installation]
  A --> D[Cursor launch links]
  B --> E[Skills catalog]
  B --> F[Checked paths and rejection reasons]
  F --> G[Collapsed detection details]
  G --> H[Copy details]
Loading

Reviews (3) · Last reviewed commit: "Preserve custom Cursor skill links and s..." · Reviewed by Greptile

Comment thread src/local/native_store.rs Outdated
Comment thread src/local/user_skills.rs
@sox8502

sox8502 commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

@greptileai review

@sox8502
sox8502 marked this pull request as ready for review October 23, 2026 22:45

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant