Repository navigation
Azure blob adapter - #1366
Azure blob adapter#1366OisinHick wants to merge 3 commits into
Conversation
amark
left a comment
amark
left a comment
There was a problem hiding this comment.
w000000000000 this is awesome, you're a hero!!! Quick couple anti-crash if-not-using-azure changes tho please.
| let containerClient; | ||
|
|
||
| const { Readable } = require('stream'); | ||
| const { BlobServiceClient, StorageSharedKeyCredential } = require("@azure/storage-blob"); |
| require('./rfs'); | ||
| require('./rs3'); | ||
| require('./wire'); | ||
| require('./azure') |
There was a problem hiding this comment.
correct! Tho, until you have it 100% working let's keep it commented out in PRs/prod. If a dev doesn't have Azure optionally NPM installed we want to make sure nothing crashes/breaks.
|
meow meow! |
|
Seem to be encountering a problem with this in that gun seems to strobe for changes and its causing an error with azure. How does gun perform or how regularly does it strobe? Might be the last hurdle facing this |
|
@OisinHick what do you mean strobe? please DM / text me other platforms. |
- Container creation and file write seem to be working perfectly. Need to verify the read is working and this should be done
c272fbd to
d729c3c
Compare
|
Hey @amark I think this is now up and running, you can ignore the tests and stuff I made. |
This branch has not been deployed
2 participants
This is a WIP adapter for Azure. It is largely working in regards to booting etc however some fine-tuning is needed to fix how it strobes for the existence of a blob on boot, however, this shouldn't take too long to fix. This request is submitted per @amark advice in the Gun Gitter chat so the community can work further on this. Huge thanks to him for all his help and guidance.