Skip to content

fix(core): unify model-visible shell output previews - #45109

Closed
opencode-agent[bot] wants to merge 2 commits into
v2from
shell-model-preview
Closed

opencode-agent[bot] wants to merge 2 commits into
v2from
shell-model-preview

Conversation

@opencode-agent

Copy link
Copy Markdown
Contributor

Summary

  • reuse one shell-output preview for model tool calls, background completions, and direct session shell commands
  • apply the same configured byte and line limits, tail selection, truncation marker, and full-output file reference on every path
  • cover oversized direct shell output and configured line limits with regression tests

Verification

  • SHELL=/bin/bash bun test test/session-create.test.ts test/tool-shell.test.ts (66 passing)
  • bun typecheck

Requested by: @rekram1-node (Aiden via Slack)

@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant