Skip to content

guardrails: a price with more than two decimals is a violation - #10

Open
vishkaty wants to merge 1 commit into
anthropics:mainfrom
vishkaty:pr/guardrails-two-decimal-prices
Open

vishkaty wants to merge 1 commit into
anthropics:mainfrom
vishkaty:pr/guardrails-two-decimal-prices

Conversation

@vishkaty

Copy link
Copy Markdown

check_guardrails accepted 79.795 and the example backends applied it as written.
Prices are money; a sub-cent value is now named as a violation at staging like
the other price rules, so no backend has to round on its own.

Found by running a conformance statement against the reference at fd4d592; the test in this change fails without the fix and passes with it. The full suite, ruff check, ruff format --check and scripts/check.py are clean on this branch.

`check_guardrails` accepted 79.795 and the example backends applied it as written.
Prices are money; a sub-cent value is now named as a violation at staging like
the other price rules, so no backend has to round on its own.
SanHsien referenced this pull request in SanHsien/commerce-agents Sep 11, 2026
購物車與契約正確性修正:quantity 驗證走 argument-error 路徑而非 outage(#8)、
guardrails 拒絕超過兩位小數的價格(#10)、retail 購物車以 Unavailable 拒絕未知/
有選項商品且 quantity<1 移除該行(#14)、stage_campaign 拒絕不存在的
campaign_id(#15)、travel 售完/不存在的 stay 不可加入購物車(#16)、
SoldOutError 改為契約的 Unavailable(#17)。全部 git apply --3way 乾淨套用,
每筆 PR 自帶的測試一併移植,逐一做過突變驗證。

docs/DIVERGENCE.md 新增 13 列登記,並更新既有 test_executor.py 一列(同時含
PR #9 與 #8 的測試);tests/test_fork_divergence.py 釘死集合同步。

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
SanHsien referenced this pull request in SanHsien/commerce-agents Sep 11, 2026
B 批六筆判決由「採納候選」改為「已採納(4dc206d)」,補後續移植紀錄段落,
格式沿用 A 批(#9、#25、#18)的做法。

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
litterbear520 added a commit to litterbear520/commerce-agents that referenced this pull request Sep 13, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016GJuJAHkpD4ccmsjHTBfyS
litterbear520 added a commit to litterbear520/commerce-agents that referenced this pull request Sep 13, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016GJuJAHkpD4ccmsjHTBfyS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants