Skip to content

GH-1385: Match the JNI return type when closing exported C Data #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hutiefang76 wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

GH-1385: Match the JNI return type when closing exported C Data #1390

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c678388
GH-1385: Match the JNI return type when closing exported C Data
hutiefang76 Oct 24, 2026
1ffa62c
GH-1385: Rely on existing C Data release coverage
hutiefang76 Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions c/src/main/cpp/jni_wrapper.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ void release_exported(T* base) {
JNIEnvGuard guard(private_data->vm_);
JNIEnv* env = guard.env();

env->CallObjectMethod(private_data->j_private_data_, kPrivateDataCloseMethod);
env->CallVoidMethod(private_data->j_private_data_, kPrivateDataCloseMethod);
if (env->ExceptionCheck()) {
// Can't signal this to caller, so log and then try to free things
// as best we can
Expand Down Expand Up @@ -295,7 +295,7 @@ void ArrowArrayStreamRelease(ArrowArrayStream* stream) {
JNIEnvGuard guard(private_data->vm_);
JNIEnv* env = guard.env();

env->CallObjectMethod(private_data->j_private_data_, kPrivateDataCloseMethod);
env->CallVoidMethod(private_data->j_private_data_, kPrivateDataCloseMethod);
if (env->ExceptionCheck()) {
env->ExceptionDescribe();
env->ExceptionClear();
Expand Down
Loading