Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2710
Rationale for this change
Native
chruses Unicode code point semantics, causing results to differ from Spark. For example,chr(321)returnsŁinstead ofA, and negative inputs raise an error instead of returning an empty string.What changes are included in this PR?
Chrto a Spark-compatibleSpark_Chrimplementation.Are there any user-facing changes?
Native
chrnow matches Spark for negative inputs and values.How was this patch tested?
Added coverage:
test_string_chrchecks scalar and array inputs, including negative values, NUL, wraparound, NULLs, and Int64 boundaries.Chr uses Spark byte-range character semanticscompareschrand its hexadecimal output against vanilla Spark using Parquet column inputs and requires native operators.Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex GPT-6.1-Sol
ASF guidance: https://www.apache.org/legal/generative-tooling.html