Skip to content

[improvement] (table stream) refactor misleading name StreamTableInfo - #65636

Merged
gavinchou merged 2 commits into
apache:masterfrom
TsukiokaKogane:refactor_stream_table_info
Jul 16, 2026
Merged

[improvement] (table stream) refactor misleading name StreamTableInfo#65636
gavinchou merged 2 commits into
apache:masterfrom
TsukiokaKogane:refactor_stream_table_info

Conversation

@TsukiokaKogane

@TsukiokaKogane TsukiokaKogane commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #65418

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

hello-stephen commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@TsukiokaKogane

TsukiokaKogane commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@TsukiokaKogane

TsukiokaKogane commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

hello-stephen commented Jul 15, 2026

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 29302 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ace1660182da55d66f08a585eb1a3573116ae17e, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17620	4068	4083	4068
q2	2008	321	203	203
q3	10285	1427	831	831
q4	4683	463	334	334
q5	7537	832	575	575
q6	187	166	146	146
q7	754	803	618	618
q8	9583	1521	1507	1507
q9	6065	4265	4269	4265
q10	6810	1742	1510	1510
q11	495	345	308	308
q12	756	551	442	442
q13	18087	3302	2713	2713
q14	262	263	262	262
q15	q16	790	780	719	719
q17	1023	955	894	894
q18	6885	5778	5591	5591
q19	1487	1261	1025	1025
q20	738	692	514	514
q21	5748	2574	2478	2478
q22	432	354	299	299
Total cold run time: 102235 ms
Total hot run time: 29302 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4460	4330	4315	4315
q2	303	318	212	212
q3	4587	4924	4383	4383
q4	2020	2143	1347	1347
q5	4350	4222	4251	4222
q6	225	172	126	126
q7	1708	1656	1890	1656
q8	2498	2261	2093	2093
q9	7773	7893	7739	7739
q10	4658	4681	4240	4240
q11	615	426	373	373
q12	747	752	532	532
q13	3495	3526	3066	3066
q14	279	296	277	277
q15	q16	706	760	660	660
q17	1364	1337	1302	1302
q18	8005	7325	7238	7238
q19	1098	1080	1064	1064
q20	2210	2225	1936	1936
q21	5183	4538	4400	4400
q22	502	484	428	428
Total cold run time: 56786 ms
Total hot run time: 51609 ms

@hello-stephen

hello-stephen commented Jul 15, 2026

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 178595 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ace1660182da55d66f08a585eb1a3573116ae17e, data reload: false

query5	4377	634	513	513
query6	457	213	203	203
query7	4844	544	346	346
query8	335	179	166	166
query9	8764	4136	4075	4075
query10	489	372	331	331
query11	5860	2331	2138	2138
query12	164	103	103	103
query13	1275	608	466	466
query14	6381	5764	4898	4898
query14_1	4233	4243	4266	4243
query15	211	210	180	180
query16	1036	477	448	448
query17	1132	733	581	581
query18	2712	485	353	353
query19	220	188	150	150
query20	114	106	105	105
query21	226	155	138	138
query22	13507	13498	13486	13486
query23	17246	16439	16078	16078
query23_1	16151	16275	16477	16275
query24	7744	1751	1334	1334
query24_1	1312	1287	1281	1281
query25	567	472	381	381
query26	1324	358	209	209
query27	2549	581	378	378
query28	4428	2013	2028	2013
query29	1070	614	494	494
query30	344	266	228	228
query31	1123	1088	979	979
query32	106	63	62	62
query33	544	323	269	269
query34	1210	1104	667	667
query35	790	781	670	670
query36	1202	1233	1085	1085
query37	155	107	92	92
query38	1871	1730	1645	1645
query39	893	878	854	854
query39_1	821	838	843	838
query40	287	160	140	140
query41	64	61	61	61
query42	93	92	90	90
query43	323	323	288	288
query44	1470	784	770	770
query45	196	185	179	179
query46	1095	1195	742	742
query47	2133	2130	2040	2040
query48	402	415	313	313
query49	581	434	306	306
query50	1030	432	333	333
query51	10674	10751	10660	10660
query52	92	84	76	76
query53	266	278	201	201
query54	300	244	220	220
query55	74	72	66	66
query56	279	295	290	290
query57	1325	1314	1194	1194
query58	277	254	261	254
query59	1584	1637	1426	1426
query60	313	276	256	256
query61	158	151	155	151
query62	542	508	432	432
query63	238	202	206	202
query64	2760	1054	913	913
query65	4602	4601	4649	4601
query66	1755	501	380	380
query67	29432	29324	29149	29149
query68	3280	1526	986	986
query69	403	300	271	271
query70	1050	957	1006	957
query71	383	365	295	295
query72	3029	2688	2373	2373
query73	864	775	457	457
query74	5087	4911	4732	4732
query75	2517	2492	2135	2135
query76	2336	1180	758	758
query77	378	392	282	282
query78	11837	11962	11399	11399
query79	1416	1107	778	778
query80	1296	544	458	458
query81	517	307	274	274
query82	650	160	125	125
query83	366	323	289	289
query84	280	161	129	129
query85	984	597	516	516
query86	443	284	293	284
query87	1828	1823	1740	1740
query88	3755	2777	2796	2777
query89	422	378	321	321
query90	1982	198	197	197
query91	205	197	161	161
query92	67	62	58	58
query93	1773	1508	922	922
query94	738	370	338	338
query95	824	486	452	452
query96	1062	856	371	371
query97	2658	2639	2530	2530
query98	215	207	207	207
query99	1111	1135	977	977
Total cold run time: 264248 ms
Total hot run time: 178595 ms

@hello-stephen

hello-stephen commented Jul 15, 2026

Copy link
Copy Markdown
Contributor
ClickBench: Total hot run time: 24.94 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ace1660182da55d66f08a585eb1a3573116ae17e, data reload: false

query1	0.00	0.00	0.00
query2	0.09	0.05	0.05
query3	0.25	0.14	0.14
query4	1.61	0.15	0.15
query5	0.24	0.23	0.22
query6	1.24	1.09	1.07
query7	0.04	0.01	0.00
query8	0.06	0.04	0.03
query9	0.39	0.31	0.32
query10	0.56	0.56	0.54
query11	0.20	0.13	0.14
query12	0.18	0.14	0.14
query13	0.47	0.49	0.48
query14	1.02	1.01	1.00
query15	0.64	0.60	0.60
query16	0.31	0.32	0.32
query17	1.13	1.11	1.09
query18	0.24	0.21	0.20
query19	2.05	1.96	1.95
query20	0.02	0.01	0.01
query21	15.42	0.25	0.14
query22	4.66	0.06	0.05
query23	16.12	0.32	0.12
query24	3.02	0.42	0.31
query25	0.11	0.06	0.04
query26	0.73	0.20	0.16
query27	0.03	0.05	0.03
query28	3.49	0.95	0.51
query29	12.48	4.07	3.19
query30	0.27	0.15	0.16
query31	2.77	0.60	0.32
query32	3.23	0.58	0.50
query33	3.14	3.20	3.17
query34	15.65	4.26	3.53
query35	3.50	3.52	3.52
query36	0.57	0.44	0.42
query37	0.09	0.07	0.07
query38	0.05	0.03	0.04
query39	0.04	0.03	0.04
query40	0.18	0.16	0.14
query41	0.09	0.04	0.03
query42	0.04	0.02	0.02
query43	0.05	0.03	0.04
Total cold run time: 96.47 s
Total hot run time: 24.94 s

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Jul 15, 2026
@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@gavinchou

gavinchou commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

/review

github-actions[bot]
github-actions Bot previously requested changes Jul 15, 2026
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review summary:

I found one blocking compatibility issue in the stream table persistence rename. The PR is small and focused, but it changes a durable Gson field name without accepting the old name, so existing stream tables can break after image load or create-table edit-log replay.

Critical checkpoint conclusions:

  • Goal: the refactor/rename is not complete safely because persisted sti records are not read by the new bti field.
  • Persistence/compatibility: blocking issue reported inline. Both table image load and create-table replay deserialize the embedded stream table through Gson.
  • Runtime/lifecycle: no separate locking or concurrency issue found; the lifecycle risk is restart/replay with baseTableInfo == null.
  • Parallel paths: image load, edit-log replay, metadata display, stream cleanup, and Nereids stream binding were checked; the accepted comment covers the shared root cause.
  • Tests: the added test only covers newly written JSON and misses legacy sti deserialization. No builds or tests were run because this review environment is instructed not to build or modify source.
  • User focus: no additional user-provided focus was supplied.

Subagent convergence completed in round 2: the final normal and risk-focused passes both returned NO_NEW_VALUABLE_FINDINGS against the accepted comment set.

Comment thread fe/fe-core/src/main/java/org/apache/doris/catalog/stream/BaseTableStream.java Resolved
@gavinchou gavinchou changed the title [improvement] (table stream) refactor misleading name StreamTableInfo… [improvement] (table stream) refactor misleading name StreamTableInfo Jul 16, 2026
@gavinchou
gavinchou merged commit a6745eb into apache:master Jul 16, 2026
31 of 43 checks passed
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Aug 17, 2026
@TsukiokaKogane @wyxxxcat
[improvement] (table stream) refactor misleading name StreamTableInfo(a…
018543a 
…pache#65636)
@morningman morningman mentioned this pull request Sep 1, 2026
Open
35 of 69 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes
@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TsukiokaKogane @hello-stephen @gavinchou