Repository navigation
branch-4.1: [fix](like) Fix LIKE matching values with extra characters at the end #68133 - #68159
Merged
Merged
Conversation
…#68133) ### What problem does this PR solve? 1. `LIKE 'a_b'` is converted to `^a.b\z`, not `^a.b$`. Hyperscan follows PCRE, where `$` also matches right before a newline that ends the value, so `^a.b$` wrongly matched 'acb\n'. `\z` is the end of the value in both Hyperscan and RE2. 2. `LIKE 'a_b%'` is converted to `^a.b`, not `^a.b.*\z`. A trailing `%` matches anything, and so does appending nothing. The anchored form would force `.*` to consume the value to its end, and `.*` only matches valid UTF-8, so RE2 would not match 'acb\xff' while Hyperscan still would. 3. `LIKE 'a_*'` is converted to `^a.\*\z`, not `^a.\*`. The tail anchor used to be skipped whenever the produced regex ended with `*`, a check meant to detect the `.*` expanded from a trailing `%`. An escaped literal `*` ends the regex with the same character, so the pattern lost its anchor entirely and `'ab*xyz'` matched. The decision now comes from the position in the pattern instead of from the produced string. Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [x] Regression test - [x] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into --> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Sep 19, 2026
Contributor
Author
|
PR approved by anyone and no changes requested. |
github-actions
Bot
added
the
approved
Contributor
Author
|
PR approved by at least one committer and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #68133