Repository navigation
Conversation
### What problem does this PR solve? Related PR: apache#68540 Problem Summary: Filesystem providers that overlap with a generic provider need an explicit fallback relationship, and provider-owned invalid properties must not disappear when another provider is selected. Add two default SPI hooks, apply them to primary/all/direct binding, and retain explicit filesystem flags and existing ordering. This prerequisite contains no GCP authentication or protocol changes. Bump the filesystem plugin API from 1.0 to 2.0. ### Release note Filesystem plugins can validate owned properties before routing and declare heuristic fallback providers. Rebuild plugins against filesystem API 2.0. ### Check List (For Author) - Test: FE Core/SPI Checkstyle, Java parsing, and git diff --check passed. Added provider-order, explicit-selection, fallback and validation tests. Standard FE UT could not reach test execution because the configured protoc executable was unavailable; unit tests were not executed. - Behavior changed: Existing providers retain their default behavior; providers can opt into validation and fallback hooks. - Does this need documentation: Yes, filesystem README updated.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Withdrawn
This draft is closed following a scope review of #68540. Native GCP IAM does not require the proposed
validateProperties()andfallbackProviders()public routing hooks.#68540 was updated in commit
0d4255d168eto use the existing filesystem SPI: GCS recognition and S3/MinIO matching exclusions stay in the relevant plugins, while credential conflicts are rejected during property binding. The generic filesystem manager retains its existing routing behavior.#69549 remains the independent resource/vault ALTER prerequisite. This PR is no longer a dependency of #68540 and should not be merged.