Repository navigation
branch-4.1: [fix](fe) Quote variant predefined field comments in generated SQL - #69755
Merged
yiguolei merged 2 commits intoOct 29, 2026
Merged
Conversation
### What problem does this PR solve? Related PR: apache#68194 Problem Summary: Unescaped quotes and backslashes in predefined VARIANT field comments make generated SQL impossible to replay. Quote comments in both type renderers and use the existing SQL literal parser. ### Release note Fix generated SQL for VARIANT predefined field comments containing quotes or backslashes. ### Check List (For Author) - Test: Unit Test - TypeTest#testVariantFieldCommentToSqlRoundTrip: passed; full TypeTest and SQL regression pending. - Behavior changed: Yes, as described above. - Does this need documentation: No
### What problem does this PR solve? Related PR: apache#68194 Problem Summary: Cover SQL rendering and parsing of VARIANT field comments containing quotes and backslashes on branch-4.1. Preserve the branch's existing type tests and use its default V1 JSON-string sink input for the DDL round-trip regression. ### Release note None ### Check List (For Author) - Test: Unit Test - TypeTest, 13 passed; Regression test - test_variant_predefine_comment_escape, 1 suite passed; build.sh --fe and Checkstyle passed. SQL regression used the newly built FE and an existing ASAN backend from the corresponding release branch. - Behavior changed: No - Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
Member
Author
|
run p0 |
yiguolei
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #68194