Repository navigation
add authentication to DownloadAction - #91
Merged
Merged
Conversation
lingbin
commented
Sep 13, 2017
lingbin
commented
Contributor
- use cluster_id as token;
- add dir limit, only files in data dir can be accessed.
1. use cluster_id as token; 2. add dir limit, only files in data dir can be accessed.
imay
requested changes
Sep 13, 2017
| CONF_Bool(disable_kudu, "false") | ||
|
|
||
| // to forward compatibility, will be removed later | ||
| CONF_Bool(disable_deprecated_download, "false"); |
Contributor
There was a problem hiding this comment.
这个配置名字不好，应该直接说明你做的是什么。比如在1年后，download模型可能更新多次了，而这个配置选项看名字都不知道在干嘛了。
另外，安全功能默认应该是开启的
Contributor
Author
There was a problem hiding this comment.
修改成enable_token_check了
|
|
||
| Status DownloadAction::check_path(const std::string& file_path) { | ||
| for (auto& allow_path : _allow_paths) { | ||
| VLOG_ROW << "allow path: " << allow_path; |
| boost::filesystem::path sub(sub_path); | ||
| parent = parent.lexically_normal(); | ||
| sub = sub.lexically_normal(); | ||
| VLOG_ROW << "parent lexically_normal: " << parent; |
| parent = parent.lexically_normal(); | ||
| sub = sub.lexically_normal(); | ||
| VLOG_ROW << "parent lexically_normal: " << parent; | ||
| VLOG_ROW << "sub lexically_normal: " << sub; |
imay
approved these changes
Sep 13, 2017
stdpain
pushed a commit
to stdpain/incubator-doris
that referenced
this pull request
Jul 5, 2021
HappenLee
added a commit
to HappenLee/incubator-doris
that referenced
this pull request
Jul 15, 2021
HappenLee
added a commit
to HappenLee/incubator-doris
that referenced
this pull request
Sep 7, 2021
2 of 3 tasks
zhangstar333
added a commit
to zhangstar333/incubator-doris
that referenced
this pull request
Oct 9, 2026
Issue Number: N/A Related PR: N/A Problem Summary: Doris pinned lance-c at 98468344bc9d56aa7ed4a4192e844afa62b34ba1 and missed upstream apache#91 vector post-filtering and scoped FTS prefiltering. Pin the dependency to 8e9e09ecc795c91ce7f97513db94c2d91eec799d, update the archive checksum, and regenerate the local Foyer patch against the new base while keeping its implementation unchanged. Include Lance-C vector post-filtering and scoped FTS prefiltering improvements. - Test: Static dependency validation: shell syntax checks, archive checksum validation, strict patch application, isolated downloader idempotence and source-tree comparison. No Doris build or unit/regression tests run. - Behavior changed: Yes; adopts upstream Lance-C apache#91 search-filter behavior. - Does this need documentation: No
zhangstar333
added a commit
to zhangstar333/incubator-doris
that referenced
this pull request
Oct 9, 2026
Issue Number: N/A Related PR: N/A Problem Summary: Doris pinned lance-c at 98468344bc9d56aa7ed4a4192e844afa62b34ba1 and missed upstream apache#91 vector post-filtering and scoped FTS prefiltering. Pin the dependency to 8e9e09ecc795c91ce7f97513db94c2d91eec799d, update the archive checksum, and regenerate the local Foyer patch against the new base while keeping its implementation unchanged. Include Lance-C vector post-filtering and scoped FTS prefiltering improvements. - Test: Static dependency validation: shell syntax checks, archive checksum validation, strict patch application, isolated downloader idempotence and source-tree comparison. No Doris build or unit/regression tests run. - Behavior changed: Yes; adopts upstream Lance-C apache#91 search-filter behavior. - Does this need documentation: No
zhangstar333
added a commit
to zhangstar333/incubator-doris
that referenced
this pull request
Oct 10, 2026
Issue Number: N/A Related PR: N/A Problem Summary: Doris pinned lance-c at 98468344bc9d56aa7ed4a4192e844afa62b34ba1 and missed upstream apache#91 vector post-filtering and scoped FTS prefiltering. Pin the dependency to 8e9e09ecc795c91ce7f97513db94c2d91eec799d, update the archive checksum, and regenerate the local Foyer patch against the new base while keeping its implementation unchanged. Include Lance-C vector post-filtering and scoped FTS prefiltering improvements. - Test: Static dependency validation: shell syntax checks, archive checksum validation, strict patch application, isolated downloader idempotence and source-tree comparison. No Doris build or unit/regression tests run. - Behavior changed: Yes; adopts upstream Lance-C apache#91 search-filter behavior. - Does this need documentation: No
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.