Repository navigation
Fix #424: mvnw respects -q/--quiet for the wrapper's own diagnostics - #474
Open
arturobernalg wants to merge 1 commit into
Open
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
…stics MavenWrapperMain prints its own messages (e.g. DefaultDownloader's "insecure connection" warning) before Maven itself ever parses the forwarded arguments, so passing -q/--quiet to mvnw had no effect on them: Logger.warn() always wrote to stderr unconditionally. Added MavenWrapperMain.isQuiet(args), a plain scan for -q/--quiet matching Maven's own CLI, called at the very start of main() to set a new Logger.setQuiet() flag; Logger.warn() now skips printing when it is set, mirroring Maven's own -q behavior of showing only errors. Added MavenWrapperMainTest for the flag detection and LoggerTest for the suppression behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-q/--quiethad no effect on the wrapper itself (e.g.DefaultDownloader's "insecure connection" warning) —Logger.warn()always wrote to stderr unconditionally, becauseMavenWrapperMainnever looked at its own forwarded arguments before printing anything, only Maven does once it starts.Added
MavenWrapperMain.isQuiet(args), a plain scan for-q/--quietmatching Maven's own CLI, called at the very start ofmain()to set a newLogger.setQuiet()flag;Logger.warn()now skips printing when it's set, mirroring Maven's own-qbehavior of showing only errors.Added
MavenWrapperMainTestfor the flag detection andLoggerTestfor the suppression behavior. Verified by reverting the fix locally and confirming the new tests fail to compile against the oldLogger/MavenWrapperMainAPI, then restoring it and confirming everything passes again. Full module test suite, checkstyle and spotless all green.To make clear that you license your contribution under the Apache License Version 2.0, January 2004, check one of the following: