Repository navigation
Conversation
Notify commit callbacks after successful manifest-list replacement and reconcile Iceberg metadata against the committed snapshot when no file delta is available. Handle retry recovery and deletion-vector refresh, with regression coverage for append and primary-key repairs, metadata retries, and deletion-vector index replacement.
Contributor
Author
|
@JingsongLi Can I get a review on the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notify commit callbacks after successful manifest-list replacement and reconcile Iceberg metadata against the committed snapshot when no file delta is available.
Handle retry recovery and deletion-vector refresh, with regression coverage for append and primary-key repairs, metadata retries, and deletion-vector index replacement.
Purpose
remove_unexisting_manifests repairs a Paimon table by replacing its manifest lists without recording a file-change delta. This bypassed commit callbacks, leaving Iceberg metadata referencing files excluded from the repaired Paimon snapshot.
Add a callback that runs after successful manifest replacement, outside the commit lock. The Iceberg implementation compares the repaired snapshot’s visible files against existing Iceberg manifests and publishes updated metadata immediately, without requiring another write or compaction.
The change also handles empty-delta overwrite snapshots during retries, refreshes deletion-vector manifests, and updates changed-partition statistics.
Tests
• IcebergCompatibilityTest: 69 tests, including seven new regression cases covering partial and complete manifest removal, primary-key repair without further compaction, retry recovery with or without previous Iceberg metadata, and retained or cleared deletion-vector indexes.
• RemoveUnexistingManifestsTest: 3 tests.
• Targeted FileStoreCommitTest methods: 5 cases covering legacy snapshots and lease-loss protection.