Skip to content

[core] Refresh Iceberg metadata after manifest replacement - #11072

Open
junmuz wants to merge 1 commit into
apache:masterfrom
junmuz:iceberg-commit-callback
Open

junmuz wants to merge 1 commit into
apache:masterfrom
junmuz:iceberg-commit-callback

Conversation

@junmuz

@junmuz junmuz commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Notify commit callbacks after successful manifest-list replacement and reconcile Iceberg metadata against the committed snapshot when no file delta is available.

Handle retry recovery and deletion-vector refresh, with regression coverage for append and primary-key repairs, metadata retries, and deletion-vector index replacement.

Purpose

remove_unexisting_manifests repairs a Paimon table by replacing its manifest lists without recording a file-change delta. This bypassed commit callbacks, leaving Iceberg metadata referencing files excluded from the repaired Paimon snapshot.

Add a callback that runs after successful manifest replacement, outside the commit lock. The Iceberg implementation compares the repaired snapshot’s visible files against existing Iceberg manifests and publishes updated metadata immediately, without requiring another write or compaction.

The change also handles empty-delta overwrite snapshots during retries, refreshes deletion-vector manifests, and updates changed-partition statistics.

Tests

• IcebergCompatibilityTest: 69 tests, including seven new regression cases covering partial and complete manifest removal, primary-key repair without further compaction, retry recovery with or without previous Iceberg metadata, and retained or cleared deletion-vector indexes.

• RemoveUnexistingManifestsTest: 3 tests.

• Targeted FileStoreCommitTest methods: 5 cases covering legacy snapshots and lease-loss protection.

Notify commit callbacks after successful manifest-list replacement and reconcile Iceberg metadata against the committed snapshot when no file delta is available.

Handle retry recovery and deletion-vector refresh, with regression coverage for append and primary-key repairs, metadata retries, and deletion-vector index replacement.
@junmuz

junmuz commented Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

@JingsongLi Can I get a review on the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant