Repository navigation
fix(divide,httpclient): attribute each HTTP attempt's outcome to its own circuit breaker (#8156) - #8253
Open
konlue wants to merge 1 commit into
Open
fix(divide,httpclient): attribute each HTTP attempt's outcome to its own circuit breaker (#8156)#8253konlue wants to merge 1 commit into
konlue wants to merge 1 commit into
Conversation
… of crediting the initial upstream (apache#8156)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8156.
Problem
With
retryStrategy = failoverthe circuit breaker recorded the outcome of the whole logical request against the initial upstream's key:DividePlugin.forwardWithCircuitBreakerwrapped the entire downstream chain (failover retries and body write-back included) withrecordOutcome(response, initialKey). A successful failover therefore credited the failed upstream with a success, clearing its consecutive failures — the breaker never opened and the upstream kept receiving initial traffic. The failover target recorded its own outcome (DefaultRetryStrategy.resend), but the initial attempt had no immediate failure record.Change
UpstreamCircuitBreaker.INITIAL_BREAKER_KEY) when retries are possible.AbstractHttpClientPlugin.executewraps the initial attempt withrecordOutcome(response, initialKey): a headers-stage failure (5xx, connect errors, timeouts) is recorded immediately, even when a failover follows; a success is credited only when no failover happens. CURRENT-policy retries record per attempt as well.Tests
InitialAttemptBreakerAttributionTestdrives the realexecute()with a per-host stubbeddoRequestand the real breaker singleton.Verification
Checkstyle clean on the three touched modules.