Repository navigation
[TINKERPOP-2558] - Proposal for First-Class Geospatial Types - #3743
Merged
Merged
Conversation
Assisted-by: Kiro:claude-opus-5.5
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3743 +/- ##
============================================
+ Coverage 76.35% 77.38% +1.02%
- Complexity 13424 14971 +1547
============================================
Files 1012 1050 +38
Lines 60341 66663 +6322
Branches 7075 7991 +916
============================================
+ Hits 46076 51588 +5512
- Misses 11548 11871 +323
- Partials 2717 3204 +487 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Reached lazy consensus. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed previously (see the devlist thread and the Jira), this proposal aims to add a first-class
Geometryvalue type to Gremlin, following SQL/MM and PostGIS.Each value carries a model,
CARTESIANorGEOGRAPHIC, backed by an SRID, which decides how it is measured. The proposal defines spatial predicates (geoWithin,geoContains,geoIntersects,geoDisjoint,geoWithinDistance,geoIntersectsBox,geoEquals) and steps (distance,buffer,envelope,asGeometry,asGeography), aGeometry(...)literal in the grammar,GTypeentries for the shapes and models, a total ordering, and a GraphBinary and GraphSON format.JTS would become a new
gremlin-coredependency.