Repository navigation
Clarify ScriptEngine prerequisites and injection risk in parameteried scripts - #3792
Merged
spmallette merged 1 commit intoNov 10, 2026
Merged
Conversation
…d scripts Note that gremlin-groovy is not enabled by default and point to the scriptEngines configuration that enables it. Qualify the gremlin-lang caveat to explain that ANTLR parsing prevents arbitrary Groovy execution but not Gremlin injection assembled from concatenated multi-statement input, so parameterization is still recommended. Label the script cache as server-internal behavior that is not directly observable from the client. Assisted-by: Kiro:claude-opus-4.8
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3792 +/- ##
============================================
+ Coverage 76.35% 77.55% +1.19%
- Complexity 13424 15027 +1603
============================================
Files 1012 1050 +38
Lines 60341 67007 +6666
Branches 7075 8004 +929
============================================
+ Hits 46076 51964 +5888
- Misses 11548 11839 +291
- Partials 2717 3204 +487 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that gremlin-groovy is not enabled by default and point to the scriptEngines configuration that enables it. Qualify the gremlin-lang caveat to explain that ANTLR parsing prevents arbitrary Groovy execution but not Gremlin injection assembled from concatenated multi-statement input, so parameterization is still recommended. Label the script cache as server-internal behavior that is not directly observable from the client.