Avoid std::exception inheritance by forge::Error class #199

Activity

1. 9prady9

   added

   api-change

   on Mar 9, 2019
2. 9prady9

   added this to the 2.0 milestone on Mar 9, 2019
3. 9prady9

   self-assigned this

   on Mar 9, 2019
4. 9prady9

   changed the title [-]Avoid inheritance std::exception by forge::Error class[/-] [+]Avoid std::exception inheritance by forge::Error class[/+] on Mar 9, 2019
5. 9prady9 commented on Jul 8, 2020

   

   9prady9

   on Jul 8, 2020

   Last edited by 9prady9

   MemberAuthor

   More actions

   https://stackoverflow.com/a/30760610/1985476

   https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-2-c4275?view=vs-2019
6. 9prady9 commented on Jul 8, 2020

   

   9prady9

   on Jul 8, 2020

   MemberAuthor

   More actions

   It seems like in-lining the fg::Error completely in the header should resolve the issue. Of course, that alone won't cut it, all cpp implementations should become header only, which shouldn't be hard given that they are merely redirecting to C-API.