Repository navigation
amazon-location-service: follow-ups from #250 review #269
Description
Deferred items from Scott's review of #250, all marked non-blocking there. Line numbers are as of 31fabbb on conniescl:update-amazon-location-v1.1.0. Paths are relative to plugins/amazon-location-service/skills/amazon-location-service/references/.
-
address-verification.md:254-waitForJobpollsGetJobin awhile (true)with no deadline or attempt cap and no retry on transientThrottlingException. AddmaxWaitMs/maxAttempts, retry transient errors, and either make the "back off" comment true or point harder at the EventBridge alternative. Also state near line 290 whether theOutput_AddressMetadata_DeliveryIndicators_*columns are always present, sincetriage()rejects every record whenMailableis absent. Thread: feat(amazon-location-service): Updated Amazon Location Service plugin to v1.1.0 #250 (comment) -
google-migration-android.md:642-routePointsis never defined in the route polyline sample andPoint.fromLngLat(it.second, it.first)assumesPair(lat, lon). Define the source explicitly:leg.geometry.lineString.map { Point.fromLngLat(it[0], it[1]) }if it comes fromCalculateRoutes(already GeoJSON order), or declareroutePoints: List<Pair<Double, Double>>as (lat, lon) and destructure. Thread: feat(amazon-location-service): Updated Amazon Location Service plugin to v1.1.0 #250 (comment) -
device-tracking.md:195- live-tracking poll does not drainNextToken(contradicts line 138) and theasyncsetIntervalcallback can overlap under throttling. Replace with a self-scheduling loop that paginates, thensetTimeout(loop, 15000). Themap.on("load")block at line 170 has the same pagination gap. Thread: feat(amazon-location-service): Updated Amazon Location Service plugin to v1.1.0 #250 (comment) -
google-migration-android.md:381-MapActivitynever callsmapView.onCreate(savedInstanceState)beforegetMapAsyncand forwards none ofonStart/onResume/onPause/onStop/onSaveInstanceState/onLowMemory/onDestroy. Add the full MapLibre lifecycle set to the sample. Thread: feat(amazon-location-service): Updated Amazon Location Service plugin to v1.1.0 #250 (comment) -
calculate-routes.md:305- the ordered lists under "When to Use Simple Format" (lines 305, 319, 326, 338, 357) and "When to Use FlexiblePolyline Format" (389, 408, 432, 453, 487, 516) all render as1.because the unindented code fences terminate each list. Use explicit sequential numbers (as at lines 1037-1039 and 1412-1414) or indent the fences and sub-bullets by 3 spaces. Line 297##### Bandwidth savings: 5-10x smaller with FlexiblePolylineshould go back to bold prose. Thread: feat(amazon-location-service): Updated Amazon Location Service plugin to v1.1.0 #250 (comment) -
zone-alerts.md:189- the comment text was corrected in 31fabbb, but theBatchEvaluateGeofencessample still does not inspectresponse.Errors. Add the check to match the guidance at line 296. Thread: feat(amazon-location-service): Updated Amazon Location Service plugin to v1.1.0 #250 (comment)
Activity