Skip to content

amazon-location-service: follow-ups from #250 review #269

Open

Description

@laithalsaadoon

Deferred items from Scott's review of #250, all marked non-blocking there. Line numbers are as of 31fabbb on conniescl:update-amazon-location-v1.1.0. Paths are relative to plugins/amazon-location-service/skills/amazon-location-service/references/.

  1. address-verification.md:254 - waitForJob polls GetJob in a while (true) with no deadline or attempt cap and no retry on transient ThrottlingException. Add maxWaitMs/maxAttempts, retry transient errors, and either make the "back off" comment true or point harder at the EventBridge alternative. Also state near line 290 whether the Output_AddressMetadata_DeliveryIndicators_* columns are always present, since triage() rejects every record when Mailable is absent. Thread: feat(amazon-location-service): Updated Amazon Location Service plugin to v1.1.0 #250 (comment)

  2. google-migration-android.md:642 - routePoints is never defined in the route polyline sample and Point.fromLngLat(it.second, it.first) assumes Pair(lat, lon). Define the source explicitly: leg.geometry.lineString.map { Point.fromLngLat(it[0], it[1]) } if it comes from CalculateRoutes (already GeoJSON order), or declare routePoints: List<Pair<Double, Double>> as (lat, lon) and destructure. Thread: feat(amazon-location-service): Updated Amazon Location Service plugin to v1.1.0 #250 (comment)

  3. device-tracking.md:195 - live-tracking poll does not drain NextToken (contradicts line 138) and the async setInterval callback can overlap under throttling. Replace with a self-scheduling loop that paginates, then setTimeout(loop, 15000). The map.on("load") block at line 170 has the same pagination gap. Thread: feat(amazon-location-service): Updated Amazon Location Service plugin to v1.1.0 #250 (comment)

  4. google-migration-android.md:381 - MapActivity never calls mapView.onCreate(savedInstanceState) before getMapAsync and forwards none of onStart/onResume/onPause/onStop/onSaveInstanceState/onLowMemory/onDestroy. Add the full MapLibre lifecycle set to the sample. Thread: feat(amazon-location-service): Updated Amazon Location Service plugin to v1.1.0 #250 (comment)

  5. calculate-routes.md:305 - the ordered lists under "When to Use Simple Format" (lines 305, 319, 326, 338, 357) and "When to Use FlexiblePolyline Format" (389, 408, 432, 453, 487, 516) all render as 1. because the unindented code fences terminate each list. Use explicit sequential numbers (as at lines 1037-1039 and 1412-1414) or indent the fences and sub-bullets by 3 spaces. Line 297 ##### Bandwidth savings: 5-10x smaller with FlexiblePolyline should go back to bold prose. Thread: feat(amazon-location-service): Updated Amazon Location Service plugin to v1.1.0 #250 (comment)

  6. zone-alerts.md:189 - the comment text was corrected in 31fabbb, but the BatchEvaluateGeofences sample still does not inspect response.Errors. Add the check to match the guidance at line 296. Thread: feat(amazon-location-service): Updated Amazon Location Service plugin to v1.1.0 #250 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions