Repository navigation
nolibc: fix integer overflow in __uring_malloc - #1544
Merged
Merged
Conversation
Owner
|
You're missing a |
The addition of sizeof(*heap) and len can overflow size_t when len is close to SIZE_MAX. This results in an undersized mmap allocation while heap->len records the small wrapped value, leading to a heap buffer overflow on subsequent writes to the returned pointer. Add an overflow check before passing the computed size to mmap. Signed-off-by: rootvector2 <dxbnaveed.k@gmail.com>
rootvector2
force-pushed
the
overflow_in__uring_malloc
branch
from
March 1, 2026 13:58
2026ecb to
8d8200d
Compare
Owner
|
Pulling this as a cleanup, there's no real issue here in terms of the liburing use cases. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The addition of sizeof(*heap) and len can overflow size_t when len is
close to SIZE_MAX. This results in an undersized mmap allocation while
heap->len records the small wrapped value, leading to a heap buffer
overflow on subsequent writes to the returned pointer.
Add an overflow check before passing the computed size to mmap.
Signed-off-by:
Naveed <dxbnaveed.k@gmail.com>